Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10775] Added a typescript precommit job #12651

Closed
wants to merge 1 commit into from

Conversation

KevinGG
Copy link
Contributor

@KevinGG KevinGG commented Aug 20, 2020

  1. The job runs 2 checks: jest for unit tests; eslint for lint and
    format.
  2. The job is triggered on change under
    sdks/python/apache_beam/runners/interactive/extensions. Any
    typescript code outside this directory needs to be explicitly added
    to the trigger pattern and the copyTsSource task.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #12651 into master will decrease coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12651      +/-   ##
==========================================
- Coverage   35.58%   34.32%   -1.26%     
==========================================
  Files          72      694     +622     
  Lines         874    82230   +81356     
  Branches        0     9295    +9295     
==========================================
+ Hits          311    28228   +27917     
- Misses        563    53571   +53008     
- Partials        0      431     +431     
Impacted Files Coverage Δ
...python/apache_beam/testing/benchmarks/sdks/python/
.../python/apache_beam/io/aws/clients/s3/sdks/python/
...ks/python/apache_beam/portability/api/sdks/python/
...ache_beam/runners/interactive/caching/sdks/python/
...pache_beam/testing/benchmarks/nexmark/sdks/python/
...ython/apache_beam/runners/portability/sdks/python/
sdks/python/apache_beam/coders/sdks/python/
sdks/python/apache_beam/testing/sdks/python/
sdks/python/apache_beam/io/flink/sdks/python/
...s/python/apache_beam/runners/internal/sdks/python/
... and 756 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf76d5...024f1d6. Read the comment docs.

@KevinGG KevinGG closed this Aug 25, 2020
@KevinGG KevinGG reopened this Aug 25, 2020
@KevinGG KevinGG closed this Aug 25, 2020
@KevinGG KevinGG reopened this Aug 25, 2020
@KevinGG
Copy link
Contributor Author

KevinGG commented Aug 27, 2020

Run Portable_Python PreCommit

1. The job runs 2 checks: jest for unit tests; eslint for lint and
   format.
2. The job is triggered on change under
   sdks/python/apache_beam/runners/interactive/extensions. Any
   typescript code outside this directory needs to be explicitly added
   to the trigger pattern and the copyTsSource task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant