[BEAM-10603] Add describe and cancel to RecordingManager #12703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohdesamuel
force-pushed
the
large-source-recording10
branch
from
bc721a8
to
b3011ad
Compare
|
Run Portable_Python PreCommit |
Codecov Report
@@ Coverage Diff @@
## master #12703 +/- ##
==========================================
+ Coverage 40.22% 40.26% +0.04%
==========================================
Files 454 455 +1
Lines 53669 53847 +178
==========================================
+ Hits 21587 21681 +94
- Misses 32082 32166 +84
Continue to review full report at Codecov.
|
Change-Id: I414463dc40a58c1452b7f4a6e819b9e054e4cac8
rohdesamuel
force-pushed
the
large-source-recording10
branch
from
b3011ad
to
a4dcca4
Compare
|
Run Python PreCommit |
1 similar comment
|
Run Python PreCommit |
|
R: @davidyan74 |
|
R: @KevinGG |
|
Run Python PreCommit |
KevinGG
approved these changes
Sep 2, 2020
sdks/python/apache_beam/runners/interactive/recording_manager.py
Outdated
Show resolved
Hide resolved
Change-Id: Ifd0bd62c95958a96728c293628b6ed5be2b38790
|
Run Portable_Python PreCommit |
|
Run PythonDocker PreCommit |
1 similar comment
|
Run PythonDocker PreCommit |
|
R: @pabloem |
|
Run Portable_Python PreCommit |
|
Run PythonDocker PreCommit |
pabloem
reviewed
Sep 8, 2020
Change-Id: Ie74c50e7624df1b0611b35fe98d12eff905520aa
rohdesamuel
force-pushed
the
large-source-recording10
branch
from
835d086
to
0d7add9
Compare
ibzib
pushed a commit
to ibzib/beam
that referenced
this pull request
Sep 30, 2020
…ncel to RecordingManager * Add describe and cancel to RecordingManager Change-Id: I414463dc40a58c1452b7f4a6e819b9e054e4cac8 * use the existing method to cancel the BCJ Change-Id: Ifd0bd62c95958a96728c293628b6ed5be2b38790 * Turn cache_key and var into properties Change-Id: Ie74c50e7624df1b0611b35fe98d12eff905520aa Co-authored-by: Sam Rohde <srohde@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I414463dc40a58c1452b7f4a6e819b9e054e4cac8
This adds the ability to introspect into the RecordingManager to get the start time and size on cache for a recording or pipeline (RecordingManager). Also adds the "cancel" method to a recording. This allows to gracefully shutdown a recording if a kernel interrupt is caught.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.