[BEAM-10760] Optimize state cleanup for global window in portable Flink runner #12733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change appears to work as expected, based on e2e test. I have not worked on the unit tests yet (couple will fail). |
mxm
reviewed
Aug 31, 2020
...rg/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
Outdated
Show resolved
Hide resolved
tweise
force-pushed
the
BEAM-10760.stateCleanup
branch
from
5659941
to
6e169f1
Compare
…nk runner Cleanup timers per key lead to potentially unbounded state/checkpoint size growth with a global window in streaming mode. Instead of timers, we can use the final watermark as the barrier to perform state cleanup.
tweise
force-pushed
the
BEAM-10760.stateCleanup
branch
from
085f8c5
to
a6f4a60
Compare
|
@mxm PTAL |
|
Unrelated error in |
|
👍 |
|
Run Portable_Python PreCommit |
|
This PR fixes the issue for portable runner only, am I right? Can we do the same for non-portable runner? |
mxm
reviewed
Sep 2, 2020
Comment on lines
+596
to
+600
| // Check if the final watermark was triggered to perform state cleanup for global window | ||
| if (potentialOutputWatermark > BoundedWindow.TIMESTAMP_MAX_VALUE.getMillis() | ||
| && currentOutputWatermark <= BoundedWindow.TIMESTAMP_MAX_VALUE.getMillis()) { | ||
| cleanupGlobalWindowState(); | ||
| } |
There was a problem hiding this comment.
This logic should be moved to DoFnOperator#emitWatermark. It can then also be simplified.
|
Followed up on this via #12759. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup timers per key lead to potentially unbounded state/checkpoint size growth with a global window in streaming mode.
Instead of timers, we can use the final watermark as the barrier to perform state cleanup.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.