-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10775] Added nodejs installation and documented Typescript precommit job #12740
Conversation
Run Typescript PreCommit |
1f90402
to
5e8e229
Compare
Run Typescript PreCommit |
1 similar comment
Run Typescript PreCommit |
5e8e229
to
5379e3c
Compare
Run Typescript PreCommit |
1 similar comment
Run Typescript PreCommit |
5379e3c
to
c9f78c0
Compare
Run Typescript PreCommit |
Codecov Report
@@ Coverage Diff @@
## master #12740 +/- ##
==========================================
- Coverage 40.22% 40.22% -0.01%
==========================================
Files 454 454
Lines 53669 53670 +1
==========================================
Hits 21587 21587
- Misses 32082 32083 +1
Continue to review full report at Codecov.
|
c9f78c0
to
a85d50f
Compare
Run Typescript PreCommit |
a85d50f
to
55b171a
Compare
Run Typescript PreCommit |
55b171a
to
03742ac
Compare
1. Added nodejs installation in scripts because Node.js is needed by jlpm. 2. Added documentation of the typescript job to pull request template and README.
03742ac
to
63ce7fe
Compare
Run Typescript PreCommit |
Run Python PreCommit failed due to BEAM-10841. This PR does not contain Python code change and the |
R: @pabloem PTAL, thx |
if command -v apt-get; then | ||
# From https://github.com/nodesource/distributions. | ||
curl -sL https://deb.nodesource.com/setup_lts.x | sudo -E bash - | ||
sudo apt-get install -y nodejs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not ssure if we can run sudo on the jenkins workers? We can try and see what happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can run sudo on Jenkins workers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll merge in a bit.
and README.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.