Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10775] Added nodejs installation and documented Typescript precommit job #12740

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

KevinGG
Copy link
Contributor

@KevinGG KevinGG commented Aug 31, 2020

  1. Added nodejs installation in scripts because Node.js is needed by jlpm.
  2. Added documentation of the typescript job to pull request template
    and README.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Portable --- Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@KevinGG
Copy link
Contributor Author

KevinGG commented Aug 31, 2020

Run Typescript PreCommit

@KevinGG
Copy link
Contributor Author

KevinGG commented Aug 31, 2020

Run Typescript PreCommit

1 similar comment
@KevinGG
Copy link
Contributor Author

KevinGG commented Aug 31, 2020

Run Typescript PreCommit

@KevinGG
Copy link
Contributor Author

KevinGG commented Aug 31, 2020

Run Typescript PreCommit

1 similar comment
@KevinGG
Copy link
Contributor Author

KevinGG commented Aug 31, 2020

Run Typescript PreCommit

@KevinGG
Copy link
Contributor Author

KevinGG commented Aug 31, 2020

Run Typescript PreCommit

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #12740 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12740      +/-   ##
==========================================
- Coverage   40.22%   40.22%   -0.01%     
==========================================
  Files         454      454              
  Lines       53669    53670       +1     
==========================================
  Hits        21587    21587              
- Misses      32082    32083       +1     
Impacted Files Coverage Δ
...beam/runners/interactive/background_caching_job.py 25.00% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa345db...63ce7fe. Read the comment docs.

@KevinGG
Copy link
Contributor Author

KevinGG commented Aug 31, 2020

Run Typescript PreCommit

@KevinGG
Copy link
Contributor Author

KevinGG commented Aug 31, 2020

Run Typescript PreCommit

1. Added nodejs installation in scripts because Node.js is needed by jlpm.
2. Added documentation of the typescript job to pull request template
   and README.
@KevinGG
Copy link
Contributor Author

KevinGG commented Aug 31, 2020

Run Typescript PreCommit

@KevinGG
Copy link
Contributor Author

KevinGG commented Aug 31, 2020

Run Python PreCommit failed due to BEAM-10841.

This PR does not contain Python code change and the Typescript ("Run Typescript PreCommit") has passed.

@KevinGG
Copy link
Contributor Author

KevinGG commented Aug 31, 2020

R: @pabloem

PTAL, thx

@KevinGG KevinGG changed the title [BEAM-10775] Added nodejs installation and documentation [BEAM-10775] Added nodejs installation and documented Typescript precommit job Sep 1, 2020
if command -v apt-get; then
# From https://github.com/nodesource/distributions.
curl -sL https://deb.nodesource.com/setup_lts.x | sudo -E bash -
sudo apt-get install -y nodejs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not ssure if we can run sudo on the jenkins workers? We can try and see what happens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can run sudo on Jenkins workers.

Copy link
Member

@pabloem pabloem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge in a bit.

@pabloem pabloem merged commit 1aa17e8 into apache:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants