[cherry-pick][BEAM-10853] Fixing copy name issue: Single name for all copies #12772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sue: Single name for all copies * Fixing copy name issue: Single name for all copies * Fix formatting * fixup * Addinga test case to verify multi-partitioned imports work. * Fixing copy job name generation
|
r: @youngoli |
|
Some of the PreCommits are failing due to the pbr license issue that was already fixed on master. I'll cherry-pick that change too. |
|
Run Portable_Python PreCommit |
|
Run PythonDocker PreCommit |
|
The remaining test failures are just PythonDocs being missing and the Dataflow containers not being built. Both expected and can be ignored for now. If the two tests I reran have no new issues I can merge this. |
youngoli
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ingle name for all copies
Fixing copy name issue: Single name for all copies
Fix formatting
fixup
Addinga test case to verify multi-partitioned imports work.
Fixing copy job name generation
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.