Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-898] Fix Jenkins BigQueryTornadoes IT Failure #1279

Closed
wants to merge 1 commit into from
Closed

[BEAM-898] Fix Jenkins BigQueryTornadoes IT Failure #1279

wants to merge 1 commit into from

Conversation

markflyhigh
Copy link
Contributor

@markflyhigh markflyhigh commented Nov 4, 2016 •
edited

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.
  • Remove @default annotation on getChecksum() in IT PipelineOption to avoid conflicts. It's related to PR-1159
  • Remove hard code input path in WordCountIT

@markflyhigh
Copy link
Contributor Author

+R: @peihe @jasonkuster

@markflyhigh markflyhigh changed the title [BEAM-898] Remove @Default from IT options [BEAM-898] Fix Jenkins BigQueryTornadoes IT Failure Nov 4, 2016
peihe
peihe reviewed Nov 4, 2016
View reviewed changes
Copy link
Contributor

@peihe peihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good as a short term fix.

@markflyhigh
Copy link
Contributor Author

+R: @lukecwik

@jasonkuster
Copy link
Contributor

LGTM as well.

@lukecwik
Copy link
Member

lukecwik commented Nov 4, 2016

Merging

@asfgit asfgit closed this in 46fbfe0 Nov 4, 2016
@markflyhigh markflyhigh deleted the fix-IT-PipelineOptions branch November 7, 2016 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peihe peihe peihe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markflyhigh @jasonkuster @lukecwik @peihe