New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-9561] Improve WontImplement reporting. #12815
Conversation
Only track as WontImplement those tests that are actually raising WontImplement errors. Also report summary on failure.
Codecov Report
@@ Coverage Diff @@
## master #12815 +/- ##
===========================================
+ Coverage 40.43% 82.36% +41.92%
===========================================
Files 449 451 +2
Lines 53502 53748 +246
===========================================
+ Hits 21635 44271 +22636
+ Misses 31867 9477 -22390
Continue to review full report at Codecov.
|
Run Portable_Python PreCommit |
R: @y1chi |
E.g. Before
after
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if m: | ||
return m.group(1) | ||
elif "NameError" in got: | ||
return "NameError" | ||
return "NameError following WontImplementError" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume all the errors here are under the precondition that WontImplementError is seen thus even the regex is not matched we know it is following WontImplementError?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct.
Run Python2_PVR_Flink PreCommit |
Only track as WontImplement those tests that are actually raising WontImplement errors.
Also report summary on failure.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.