Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9561] Initial framework for testing pandas website docs. #12819

Merged
merged 16 commits into from Oct 1, 2020

Conversation

robertwb
Copy link
Contributor


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@robertwb
Copy link
Contributor Author

R: @TheNeuralBit

@robertwb robertwb marked this pull request as draft September 11, 2020 19:12
@robertwb robertwb marked this pull request as ready for review September 11, 2020 20:01
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #12819 into master will increase coverage by 0.13%.
The diff coverage is 96.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12819      +/-   ##
==========================================
+ Coverage   82.31%   82.44%   +0.13%     
==========================================
  Files         455      455              
  Lines       54596    54864     +268     
==========================================
+ Hits        44941    45233     +292     
+ Misses       9655     9631      -24     
Impacted Files Coverage Δ
sdks/python/apache_beam/dataframe/doctests.py 96.75% <96.22%> (-0.45%) ⬇️
...dks/python/apache_beam/options/pipeline_options.py 93.76% <0.00%> (-1.03%) ⬇️
sdks/python/apache_beam/io/gcp/bigquery.py 80.08% <0.00%> (-0.63%) ⬇️
sdks/python/apache_beam/io/fileio.py 95.80% <0.00%> (-0.05%) ⬇️
...e_beam/portability/api/beam_runner_api_pb2_urns.py 100.00% <0.00%> (ø)
..._beam/runners/portability/sdk_container_builder.py 31.21% <0.00%> (ø)
...eam/testing/benchmarks/nexmark/nexmark_launcher.py 0.00% <0.00%> (ø)
...ache_beam/runners/interactive/recording_manager.py 98.90% <0.00%> (+0.02%) ⬆️
sdks/python/apache_beam/transforms/environments.py 83.73% <0.00%> (+0.19%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c38fa68...a0a3099. Read the comment docs.

@robertwb
Copy link
Contributor Author

Run Python PreCommit

@robertwb
Copy link
Contributor Author

The apache_beam.transforms.ptransform_test.PTransformTest.test_flatten_no_pcollections failure looks unrelated.

@robertwb
Copy link
Contributor Author

Run Python PreCommit

@robertwb
Copy link
Contributor Author

Same test_flatten_no_pcollections failure.

Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor comments

sdks/python/apache_beam/dataframe/doctests_test.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/dataframe/pandas_docs_test.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/dataframe/doctests.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/dataframe/doctests.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/dataframe/pandas_docs_test.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/dataframe/doctests.py Show resolved Hide resolved
@robertwb
Copy link
Contributor Author

Run Python PreCommit

1 similar comment
@robertwb
Copy link
Contributor Author

robertwb commented Oct 1, 2020

Run Python PreCommit

@TheNeuralBit
Copy link
Member

Failure looks like BEAM-10987

@robertwb robertwb merged commit 2e9b34e into apache:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants