Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7523] Enable KafkaCSVTableIT using KafkaContainer #12826

Merged
merged 1 commit into from Sep 11, 2020

Conversation

pjotrekk
Copy link

R: @TheNeuralBit


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@pjotrekk
Copy link
Author

Run SQL PostCommit

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #12826 into master will increase coverage by 41.97%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #12826       +/-   ##
===========================================
+ Coverage   40.38%   82.35%   +41.97%     
===========================================
  Files         451      451               
  Lines       53721    53750       +29     
===========================================
+ Hits        21696    44267    +22571     
+ Misses      32025     9483    -22542     
Impacted Files Coverage Δ
sdks/python/apache_beam/coders/slow_stream.py 92.43% <0.00%> (+1.68%) ⬆️
sdks/python/apache_beam/utils/profiler.py 32.11% <0.00%> (+1.83%) ⬆️
...on/apache_beam/runners/direct/sdf_direct_runner.py 36.21% <0.00%> (+2.46%) ⬆️
sdks/python/apache_beam/coders/coder_impl.py 95.25% <0.00%> (+2.64%) ⬆️
sdks/python/apache_beam/io/azure/blobstorageio.py 26.95% <0.00%> (+3.19%) ⬆️
sdks/python/apache_beam/utils/proto_utils.py 63.07% <0.00%> (+4.61%) ⬆️
...pache_beam/examples/cookbook/bigquery_tornadoes.py 45.00% <0.00%> (+5.00%) ⬆️
...runners/interactive/options/interactive_options.py 86.66% <0.00%> (+6.66%) ⬆️
...apache_beam/examples/cookbook/custom_ptransform.py 53.48% <0.00%> (+6.97%) ⬆️
...beam/portability/api/beam_artifact_api_pb2_grpc.py 56.98% <0.00%> (+7.52%) ⬆️
... and 268 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5705526...5a98624. Read the comment docs.

@TheNeuralBit
Copy link
Member

Run SQL PostCommit

@TheNeuralBit
Copy link
Member

Failure is due to BEAM-10886

Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TheNeuralBit TheNeuralBit merged commit 224b1d4 into apache:master Sep 11, 2020
ibzib pushed a commit to ibzib/beam that referenced this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants