Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental declarations from fileio. #12873

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

robertwb
Copy link
Contributor


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@robertwb
Copy link
Contributor Author

R: @pabloem
CC: @chamikaramj

Let me know if you think some or all of this should remain experimental.

@pabloem
Copy link
Member

pabloem commented Sep 21, 2020

Can we keep WriteToFiles as experimental? I would like to spend some time figuring out a couple questions about how it handles sharding before fully marking it as stable. I filed https://issues.apache.org/jira/browse/BEAM-10939 to track this.

Except for that comment, everything else LGTM. Thanks @robertwb

@robertwb
Copy link
Contributor Author

Sure, we can keep it experimental a bit longer. I would like to fix #12900 though.

@pabloem
Copy link
Member

pabloem commented Sep 29, 2020

feel free to merge @robertwb except for the change to WriteToFiles all others lgtm

@robertwb
Copy link
Contributor Author

Thanks. Re-instated the annotation on WriteToFiles.

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #12873 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12873      +/-   ##
==========================================
+ Coverage   82.31%   82.34%   +0.03%     
==========================================
  Files         451      455       +4     
  Lines       53874    54647     +773     
==========================================
+ Hits        44344    44999     +655     
- Misses       9530     9648     +118     
Impacted Files Coverage Δ
sdks/python/apache_beam/io/fileio.py 95.80% <ø> (+2.07%) ⬆️
...am/runners/interactive/options/capture_limiters.py 90.47% <0.00%> (-3.08%) ⬇️
sdks/python/apache_beam/dataframe/schemas.py 97.56% <0.00%> (-2.44%) ⬇️
sdks/python/apache_beam/io/gcp/pubsub.py 92.30% <0.00%> (-1.28%) ⬇️
...dks/python/apache_beam/runners/pipeline_context.py 92.80% <0.00%> (-1.01%) ⬇️
sdks/python/apache_beam/dataframe/convert.py 88.88% <0.00%> (-0.70%) ⬇️
...s/python/apache_beam/io/gcp/bigquery_file_loads.py 89.97% <0.00%> (-0.63%) ⬇️
sdks/python/apache_beam/io/iobase.py 83.75% <0.00%> (-0.58%) ⬇️
sdks/python/apache_beam/io/avroio.py 61.00% <0.00%> (-0.36%) ⬇️
sdks/python/apache_beam/transforms/environments.py 83.54% <0.00%> (-0.33%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbda220...9e33bf8. Read the comment docs.

@robertwb robertwb merged commit 36268e1 into apache:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants