-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimental declarations from fileio. #12873
Conversation
R: @pabloem Let me know if you think some or all of this should remain experimental. |
Can we keep WriteToFiles as experimental? I would like to spend some time figuring out a couple questions about how it handles sharding before fully marking it as stable. I filed https://issues.apache.org/jira/browse/BEAM-10939 to track this. Except for that comment, everything else LGTM. Thanks @robertwb |
Sure, we can keep it experimental a bit longer. I would like to fix #12900 though. |
feel free to merge @robertwb except for the change to WriteToFiles all others lgtm |
eeed5d9
to
69178e9
Compare
Thanks. Re-instated the annotation on WriteToFiles. |
69178e9
to
9e33bf8
Compare
Codecov Report
@@ Coverage Diff @@
## master #12873 +/- ##
==========================================
+ Coverage 82.31% 82.34% +0.03%
==========================================
Files 451 455 +4
Lines 53874 54647 +773
==========================================
+ Hits 44344 44999 +655
- Misses 9530 9648 +118
Continue to review full report at Codecov.
|
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.