Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update indexing skips for pandas 1.x #12896

Merged
merged 4 commits into from
Sep 21, 2020
Merged

Update indexing skips for pandas 1.x #12896

merged 4 commits into from
Sep 21, 2020

Conversation

TheNeuralBit
Copy link
Member

Fix PreCommit breakage due to race between #12869 and #12856.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

Copy link
Contributor

@ibzib ibzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #12896 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12896      +/-   ##
==========================================
- Coverage   82.34%   82.33%   -0.02%     
==========================================
  Files         452      452              
  Lines       54016    54016              
==========================================
- Hits        44481    44473       -8     
- Misses       9535     9543       +8     
Impacted Files Coverage Δ
sdks/python/apache_beam/io/localfilesystem.py 90.90% <0.00%> (-0.76%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.80% <0.00%> (-0.54%) ⬇️
sdks/python/apache_beam/runners/common.py 88.75% <0.00%> (-0.45%) ⬇️
...eam/runners/portability/fn_api_runner/fn_runner.py 89.53% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df7495...aaecf18. Read the comment docs.

@TheNeuralBit
Copy link
Member Author

Run Python_PVR_Flink PreCommit

1 similar comment
@TheNeuralBit
Copy link
Member Author

Run Python_PVR_Flink PreCommit

@TheNeuralBit
Copy link
Member Author

PVR_Flink is now disabled: https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Commit I don't think the failure is related.

@TheNeuralBit TheNeuralBit merged commit 1b26660 into master Sep 21, 2020
@ibzib
Copy link
Contributor

ibzib commented Sep 21, 2020

PVR_Flink is now disabled: https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Commit I don't think the failure is related.

That's unexpected.. I wonder if it was disabled accidentally (perhaps because of Python version removals?)

@TheNeuralBit
Copy link
Member Author

I think that job is actually a new one added in #12898. There's still https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Commit/

@tvalentyn
Copy link
Contributor

That's unexpected.. I wonder if it was disabled accidentally (perhaps because of Python version removals?)

Yes, sorry about that - I was testing my changes and ran a seed job on #12898

@tvalentyn tvalentyn deleted the indexing-pandas1 branch September 22, 2020 00:57
ibzib pushed a commit to ibzib/beam that referenced this pull request Sep 30, 2020
* Update indexing skips for pandas 1.x

* fix typo

* remove extra line

* Exclude both 0.x and 1.x versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants