-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10871] Fix FhirLROIT tests #12902
Conversation
Run Java PostCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! I'll merge when Java PostCommit passes
@TheNeuralBit Would you please hold on merging, I realized that there could be flakiness issue for the existing tests. I'll investigate. |
ok I'll hold off, thanks |
@TheNeuralBit ok fixed. I tried to run the test 10 times and they all passed. |
Run Java PostCommit |
@trucleduc there was a failure:
|
Run Java PostCommit |
…is is to follow-up [BEAM-10871] Add deidentify for FhirIO connector apache#12721 R: @pabloem
Run Java PostCommit |
* Add export FHIR resources to GCS method for HealthcareApiClient. * Add export FHIR resources to GCS method for HealthcareApiClient. * Add export FHIR resources to GCS method for HealthcareApiClient. * Add export FHIR resources to GCS IO connector. * Add export FHIR resources to GCS IO connector. * Add export FHIR resources to GCS IO connector. * Add export FHIR resources to GCS IO connector. * Add export FHIR resources to GCS IO connector. * Add export FHIR resources to GCS IO connector. * Add export FHIR resources to GCS IO connector. * Add export FHIR resources to GCS IO connector. * Add export FHIR resources to GCS IO connector. * Add deidentify FHIR resources IO connector. * Add deidentify FHIR resources IO connector. * Add deidentify FHIR resources IO connector. * Add deidentify FHIR resources IO connector. * Add deidentify FHIR resources IO connector. * Add deidentify FHIR resources IO connector. * Add deidentify FHIR resources IO connector. * Add deidentify FHIR resources IO connector. * Add deidentify FHIR resources IO connector. * Add deidentify FHIR resources IO connector. * Add deidentify FHIR resources IO connector. * Add deidentify FHIR resources IO connector. * Add deidentify FHIR resources IO connector. * Only delete FHIR stores that were being used in FhirIOLROIT tests. This is to follow-up [BEAM-10871] Add deidentify for FhirIO connector apache#12721 R: @pabloem * Correct FhirLROIT test. * Fix FhirLROIT tests * Fix FhirLROIT tests
Please add a meaningful description for your change here
In #12721 , we delete all FHIR stores in the clean up which may interfere with other integration tests. This PR fixes this by only deleting FHIR stores generated by the test.
R: @pabloem
R: @TheNeuralBit
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.