Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9026] Avoid side effects from positional value provider arguments. #12989

Merged
merged 1 commit into from Oct 1, 2020

Conversation

ibzib
Copy link
Contributor

@ibzib ibzib commented Oct 1, 2020

This doesn't address the root cause of this issue, which is that value provider arguments are still leaking into unrelated tests.

R: @udim @tvalentyn


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

This doesn't address the root cause of this issue, which is that value provider arguments are still leaking into unrelated tests.
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #12989 into master will increase coverage by 0.12%.
The diff coverage is 79.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12989      +/-   ##
==========================================
+ Coverage   82.39%   82.51%   +0.12%     
==========================================
  Files         453      453              
  Lines       54623    54610      -13     
==========================================
+ Hits        45005    45061      +56     
+ Misses       9618     9549      -69     
Impacted Files Coverage Δ
sdks/python/apache_beam/io/fileio.py 95.80% <ø> (ø)
sdks/python/apache_beam/io/gcp/bigquery.py 80.23% <0.00%> (+0.14%) ⬆️
sdks/python/apache_beam/io/gcp/bigquery_tools.py 88.35% <0.00%> (ø)
...eam/testing/benchmarks/nexmark/nexmark_launcher.py 0.00% <0.00%> (ø)
...pache_beam/runners/interactive/interactive_beam.py 79.53% <66.66%> (ø)
...dks/python/apache_beam/options/pipeline_options.py 93.76% <70.58%> (ø)
sdks/python/apache_beam/transforms/environments.py 83.73% <83.33%> (ø)
.../apache_beam/options/pipeline_options_validator.py 98.69% <100.00%> (ø)
...ache_beam/runners/interactive/recording_manager.py 98.90% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4161140...52698a4. Read the comment docs.

@udim
Copy link
Member

udim commented Oct 1, 2020

Looks like a good workaround. I also commented on the bug

@ibzib ibzib merged commit ad2d778 into apache:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants