[BEAM-8017] Plumb errors and remove panics from package graphx #13028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @lostluck |
lostluck
requested changes
Oct 7, 2020
There was a problem hiding this comment.
Wow thanks! This is great!
Most of my suggestions are to adjust the error messages to the idomatic "errors don't start with capital letters". The rule exists since often times the messages get concatenated or later included in logs, which tends to read funny.
Otherwise there were some odd inclusions of extra blank lines, which have been similarly removed.
There are two spots where in addition to the standard if err != nil { boilerplate there was a fair amount of repetition due to repeating the same error message. I've added a suggestion for how to reduce that repetition.
Thanks for the contribution!
Exported methods and functions in package graphx are not backwards compatible, APIs return an extra error indicating roots of failures
lostluck
approved these changes
Oct 8, 2020
fix typo of scope.
|
Run Go PostCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
The PR removes panic from package graphx
Exported methods and functions in package graphx are not backwards compatible, APIs return an extra error indicating roots of failures
Methods and functions outside graphx, it follows how they handle error, either return error back to callers or panic, which does't impact compatibility.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.