Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-11045] Fix screendiff integration tests #13052

Closed
wants to merge 1 commit into from

Conversation

KevinGG
Copy link
Contributor

@KevinGG KevinGG commented Oct 8, 2020

  1. Removed the server daemon process from screen diff tests because it's
    not compatible with Py3.8. Replaced it with a lightweight daemon thread.
  2. Upgraded chromedriver-binary version to 85 to match the newest chrome
    browser version and updated the goldens to match the iframe changed
    introduced in PR#13045.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

1. Removed the server daemon process from screen diff tests. Replaced it
   with a lightweight daemon thread.
2. Upgraded chromedriver-binary version to 85 to match the newest chrome
   browser version and updated the goldens to match the iframe changed
   introduced in PR#13045.
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #13052 into master will decrease coverage by 0.00%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13052      +/-   ##
==========================================
- Coverage   82.49%   82.48%   -0.01%     
==========================================
  Files         455      455              
  Lines       54867    54870       +3     
==========================================
- Hits        45263    45261       -2     
- Misses       9604     9609       +5     
Impacted Files Coverage Δ
...ers/interactive/testing/integration/screen_diff.py 28.45% <0.00%> (+0.54%) ⬆️
...hon/apache_beam/runners/dataflow/internal/names.py 100.00% <100.00%> (ø)
sdks/python/apache_beam/utils/interactive_utils.py 92.85% <0.00%> (-2.39%) ⬇️
sdks/python/apache_beam/io/localfilesystem.py 91.66% <0.00%> (-0.76%) ⬇️
sdks/python/apache_beam/io/gcp/bigquery_tools.py 87.79% <0.00%> (-0.57%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 94.34% <0.00%> (-0.14%) ⬇️
...beam/runners/portability/local_job_service_main.py 0.00% <0.00%> (ø)
...runners/interactive/display/pcoll_visualization.py 85.34% <0.00%> (+0.07%) ⬆️
sdks/python/apache_beam/io/iobase.py 84.03% <0.00%> (+0.28%) ⬆️
...eam/runners/interactive/interactive_environment.py 89.80% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a27faca...8d19542. Read the comment docs.

@KevinGG KevinGG closed this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant