[BEAM-11375] Downgrade Kafka clients dependency to fix spark postcommit #13458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjotrekk
force-pushed
the
kafka-scala-update
branch
from
f4c264a
to
2216e81
Compare
Merged
4 tasks
pjotrekk
force-pushed
the
kafka-scala-update
branch
from
2216e81
to
3b603e7
Compare
pjotrekk
changed the title
pjotrekk
force-pushed
the
kafka-scala-update
branch
from
3b603e7
to
03a52ad
Compare
pjotrekk
changed the title
pjotrekk
force-pushed
the
kafka-scala-update
branch
from
03a52ad
to
8e6dae8
Compare
|
Run Spark ValidatesRunner |
|
Run Java PostCommit |
1 similar comment
|
Run Java PostCommit |
|
@aromanenko-dev @ibzib It looks like Spark postcommit is working again. Updating Scala version broke everything so it indeed looks like we have to wait until Spark supports Scala 2.12. Strangely SpannerIOIT tests keep failing - I'm not sure if it's related to this PR but it looks more like Beam's GCP project issue: |
iemejia
approved these changes
Dec 2, 2020
|
@piotr-szuberski Thanks! I don't think SpannerIOIT fails are related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #13026 has broken Spark postcommit because of Kafka dependencies mismatch.
Starting with Kafka clients 2.5.0 Scala 2.11 is no longer supported.
This PR reverts Kafka client to 2.4.1
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.