Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9980] Combine job_PostCommit_Python*.groovy files into one #13461

Merged

Conversation

lazylynx
Copy link
Contributor

@lazylynx lazylynx commented Dec 2, 2020

remove job_PostCommit_Python(36|37|38).groovy and integrate to one.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@lazylynx lazylynx force-pushed the integrate_python_postcommit_job_file branch from ddf68bf to 09d473a Compare December 6, 2020 06:51
@lazylynx
Copy link
Contributor Author

lazylynx commented Dec 6, 2020

R: @tvalentyn

Copy link
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks a lot, @lazylynx !
I just need to test it in a seed job to make sure there are no surprizes.

"Python${versionSuffix}_PC(\"Run Python ${pythonVersion} PostCommit\")", this) {
description('Runs Python postcommit tests using Python ${pythonVersion}.')

previousNames('/beam_PostCommit_Python3_Verify/')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think this is a no longer necessary leftover, I'll remove it.

@tvalentyn tvalentyn changed the title [BEAM-9980] make job_PostCommit_Python*.groovy files to one [BEAM-9980] Combine job_PostCommit_Python*.groovy files into one Dec 28, 2020
@tvalentyn tvalentyn merged commit 9f234d6 into apache:master Dec 28, 2020
@lazylynx lazylynx deleted the integrate_python_postcommit_job_file branch January 7, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants