[BEAM-11407] Add IT tests to Bigtable for BeamSQL #13512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amaliujia I've added integration tests with some refactor to avoid code duplication and import restriction in the gcp package. I've run BigtableTableIT on real Bigtable and it is working. This PR is based on the PR with filters so I'll leave it as draft for now. |
pjotrekk
force-pushed
the
bigtable-it
branch
4 times, most recently
from
1c9210f
to
5cda774
Compare
pjotrekk
force-pushed
the
bigtable-it
branch
from
5cda774
to
3cacd4a
Compare
|
Run Java PreCommit |
|
Run SQL PostCommit |
|
@amaliujia I've rebased it. I think it's ready for review. I've separated testing utils from the io/gcp and extensions/sql packages. I think it is clearer now and does not cause imports issues which was the case when I tried to keep it as before. |
|
Will give a review soon. |
amaliujia
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent on #13495 - do not merge it before this one is merged.
Added integration test for Bigtable for BeamSQL and done some refactor to test utils to avoid package and classes errors in GcpApiSurfaceTest.
I've tested BigtableTableIT with real Bigtable - everything seems to be working.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.