Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-10556][BEAM-10402] Cleanup DoFnOperatorTest warnings. #13521

Merged
merged 1 commit into from Dec 10, 2020
Merged

[BEAM-10556][BEAM-10402] Cleanup DoFnOperatorTest warnings. #13521

merged 1 commit into from Dec 10, 2020
+63 −82

Conversation

dmvk
Copy link
Member

@dmvk dmvk commented Dec 10, 2020

https://issues.apache.org/jira/browse/BEAM-10556
https://issues.apache.org/jira/browse/BEAM-10402

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status		 Build Status
Build Status
Build Status
Build Status		 Build Status Build Status
Build Status
Build Status		 Build Status
Python Build Status
Build Status
Build Status		 Build Status
Build Status
Build Status		 Build Status
Build Status		 --- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status		 Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@dmvk
Copy link
Member Author

dmvk commented Dec 10, 2020

R: @mxm

@dmvk
Copy link
Member Author

dmvk commented Dec 10, 2020

Run Java PreCommit

mxm
mxm approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@mxm mxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to clean these up! Will feel much better looking at this test class :)

@mxm mxm merged commit 33b3ac4 into apache:master Dec 10, 2020
@ccciudatu
Copy link
Contributor

This seems to break compileTestJava for all :runners:flink

@ccciudatu ccciudatu mentioned this pull request Dec 10, 2020
Merged
4 tasks
@dmvk
Copy link
Member Author

dmvk commented Dec 10, 2020

@ccciudatu let me check if I can fix it really quick, otherwise I'll revert this

@dmvk dmvk mentioned this pull request Dec 10, 2020
Merged
4 tasks
@dmvk dmvk deleted the flink_test_warnings branch December 10, 2020 22:43
@mxm
Copy link
Contributor

mxm commented Dec 11, 2020

Sorry about that. I was pretty sure that the tests had passed when I merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxm mxm mxm approved these changes

Assignees
No one assigned
Labels
flink runners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmvk @ccciudatu @mxm