Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10961] Enabled strict dependency in metrics extension library #13657

Merged
merged 2 commits into from Jan 20, 2021

Conversation

sonam-vend
Copy link
Contributor

@sonam-vend sonam-vend commented Jan 5, 2021

Since enabling the strict dependencies on all Java modules is a large and critical change to be merged all at once. Therefore, task [BEAM-10961] is divided into sub-tasks and strict dependencies are enabled to each module separately which is comparatively easy to review and merge.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@sonam-vend
Copy link
Contributor Author

R: @ibzib , @aaltay can you please review or add reviewers who can review this.

@sonam-vend sonam-vend changed the title Enabled strict dependency on Extensions Java runner [BEAM-10961] Enabled strict dependency on Extensions Java runner Jan 8, 2021
@sonam-vend
Copy link
Contributor Author

R: @tysonjh

@ibzib ibzib changed the title [BEAM-10961] Enabled strict dependency on Extensions Java runner [BEAM-10961] Enabled strict dependency in metrics extension library Jan 20, 2021
Copy link
Contributor

@ibzib ibzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibzib ibzib merged commit 0bfdf6c into apache:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants