New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10961] Enabled strict Dependency on Portability #13666
Conversation
Run Java PreCommit |
3 similar comments
Run Java PreCommit |
Run Java PreCommit |
Run Java PreCommit |
R: @tysonjh |
@@ -19,7 +19,7 @@ import groovy.json.JsonOutput | |||
*/ | |||
|
|||
plugins { id 'org.apache.beam.module' } | |||
applyJavaNature(automaticModuleName: 'org.apache.beam.runners.portability') | |||
applyJavaNature(enableStrictDependencies:true, automaticModuleName: 'org.apache.beam.runners.portability') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: add space
applyJavaNature(enableStrictDependencies:true, automaticModuleName: 'org.apache.beam.runners.portability') | |
applyJavaNature(enableStrictDependencies: true, automaticModuleName: 'org.apache.beam.runners.portability') |
Run Java PreCommit |
1 similar comment
Run Java PreCommit |
Run Java PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since enabling the strict dependencies on all Java modules is a large and critical change to be merged all at once. Therefore, task [BEAM-10961] is divided into sub-tasks and strict dependencies are enabled to each module separately which is comparatively easy to review and merge.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.