Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-10961] Enabled strict dependencies on samza #13667

Merged
merged 5 commits into from
Jan 21, 2021
Merged

[BEAM-10961] Enabled strict dependencies on samza #13667

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e908810
Enabled strict dependencies on samza
sonam-vend Jan 5, 2021
b7015c2
resolved requested changes
sonam-vend Jan 21, 2021
a759860
removed duplicate occurence of checker-qual
sonam-vend Jan 21, 2021
9cc25c4
Remove obsolete comment.
ibzib Jan 21, 2021
8c693a6
Remove stray colon.
ibzib Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 11 additions & 10 deletions runners/samza/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import groovy.json.JsonOutput

plugins { id 'org.apache.beam.module' }
applyJavaNature(
enableStrictDependencies : true,
exportJavadoc: false,
classesTriggerCheckerBugs: [
'GroupWithoutRepartition': 'https://github.com/typetools/checker-framework/issues/3791',
Expand Down Expand Up @@ -53,21 +54,21 @@ dependencies {
compile library.java.slf4j_api
compile library.java.joda_time
compile library.java.commons_io
compile library.java.commons_lang3
compile library.java.args4j
compile "javax.servlet:javax.servlet-api:3.1.0"
compile "io.dropwizard.metrics:metrics-core:3.1.2"
compile "org.rocksdb:rocksdbjni:5.7.3"
compile "org.apache.commons:commons-collections4:4.0"
compile "org.scala-lang:scala-library:2.11.8"
runtimeOnly "org.rocksdb:rocksdbjni:5.7.3"
runtimeOnly "org.scala-lang:scala-library:2.11.8"
compile "org.apache.samza:samza-api:$samza_version"
compile "org.apache.samza:samza-core_2.11:$samza_version"
compile "org.apache.samza:samza-kafka_2.11:$samza_version"
compile "org.apache.samza:samza-kv_2.11:$samza_version"
runtimeOnly "org.apache.samza:samza-kafka_2.11:$samza_version"
runtimeOnly "org.apache.samza:samza-kv_2.11:$samza_version"
compile project(":sdks:java:expansion-service")
compile "org.apache.samza:samza-kv-rocksdb_2.11:$samza_version"
compile "org.apache.samza:samza-kv-inmemory_2.11:$samza_version"
compile "org.apache.samza:samza-yarn_2.11:$samza_version"
compile "org.apache.kafka:kafka-clients:0.11.0.2"
runtimeOnly "org.apache.kafka:kafka-clients:0.11.0.2"
compile library.java.vendored_grpc_1_26_0
compile project(path: ":model:job-management:", configuration: "shadow")
ibzib marked this conversation as resolved.
Show resolved Hide resolved
compile project(path: ":model:pipeline", configuration: "shadow")
compile project(":sdks:java:fn-execution")
testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
testCompile project(path: ":runners:core-java", configuration: "testRuntime")
testCompile library.java.hamcrest_core
Expand Down
2 changes: 2 additions & 0 deletions runners/samza/job-server/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ apply plugin: 'application'
mainClassName = "org.apache.beam.runners.samza.SamzaJobServerDriver"

applyJavaNature(
enableStrictDependencies : true,
automaticModuleName: 'org.apache.beam.runners.samza.jobserver',
validateShadowJar: false,

Expand All @@ -33,6 +34,7 @@ applyJavaNature(

dependencies {
compile project(":runners:samza")
sonam-vend marked this conversation as resolved.
Show resolved Hide resolved
permitUnusedDeclared project(":runners:samza")
runtime group: "org.slf4j", name: "jcl-over-slf4j", version: dependencies.create(project.library.java.slf4j_api).getVersion()
runtime library.java.slf4j_simple
}
Expand Down