Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10120] Add dynamic timer support to portable Flink #13783

Merged
merged 1 commit into from Jan 28, 2021

Conversation

boyuanzz
Copy link
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@boyuanzz boyuanzz changed the title [WIP] Add dynamic timer support to portable Flink and Spark. [BEAM-10120] Add dynamic timer support to portable Flink and Spark. Jan 21, 2021
@boyuanzz
Copy link
Contributor Author

Run Java Flink PortableValidatesRunner Streaming

@boyuanzz
Copy link
Contributor Author

Run Java Flink PortableValidatesRunner Batch

@boyuanzz
Copy link
Contributor Author

Run Java Spark PortableValidatesRunner Batch

@boyuanzz
Copy link
Contributor Author

Run Java Spark PortableValidatesRunner Streaming

@boyuanzz
Copy link
Contributor Author

boyuanzz commented Jan 21, 2021

r: @ibzib @mxm
cc: @y1chi @tysonjh

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #13783 (b8c8bf3) into master (a724602) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13783      +/-   ##
==========================================
- Coverage   82.76%   82.74%   -0.02%     
==========================================
  Files         466      466              
  Lines       57525    57525              
==========================================
- Hits        47612    47601      -11     
- Misses       9913     9924      +11     
Impacted Files Coverage Δ
sdks/python/apache_beam/utils/interactive_utils.py 88.09% <0.00%> (-4.77%) ⬇️
...hon/apache_beam/runners/direct/test_stream_impl.py 91.91% <0.00%> (-2.21%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 86.45% <0.00%> (-1.05%) ⬇️
sdks/python/apache_beam/io/localfilesystem.py 91.66% <0.00%> (-0.76%) ⬇️
...eam/runners/interactive/interactive_environment.py 89.92% <0.00%> (-0.36%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.85% <0.00%> (-0.32%) ⬇️
sdks/python/apache_beam/transforms/util.py 95.66% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a724602...b8c8bf3. Read the comment docs.

@boyuanzz
Copy link
Contributor Author

Run Python_PVR_Flink PreCommit

@boyuanzz boyuanzz changed the title [BEAM-10120] Add dynamic timer support to portable Flink and Spark. [BEAM-10120] Add dynamic timer support to portable Flink Jan 21, 2021
@boyuanzz
Copy link
Contributor Author

It seems like Spark doesn't support timers in portable execution. The changes I have made to java runner shared library can also used by Spark in the future. @ibzib

@ibzib
Copy link
Contributor

ibzib commented Jan 21, 2021

It seems like Spark doesn't support timers in portable execution. The changes I have made to java runner shared library can also used by Spark in the future. @ibzib

Portable Spark supports timers in batch, but not streaming mode.

@boyuanzz
Copy link
Contributor Author

Run Java Flink PortableValidatesRunner Streaming

@boyuanzz
Copy link
Contributor Author

Run Java Flink PortableValidatesRunner Batch

@boyuanzz
Copy link
Contributor Author

Run Java Flink PortableValidatesRunner Streaming

@boyuanzz
Copy link
Contributor Author

Run Python_PVR_Flink PreCommit

@boyuanzz boyuanzz requested a review from mxm January 25, 2021 18:56
Copy link
Contributor

@ibzib ibzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@boyuanzz
Copy link
Contributor Author

Thanks for the review!

I'm going to merge this PR. Feel free to drop any comments here if you have any concerns @mxm . I'll follow up with any comments.

@boyuanzz boyuanzz merged commit 73731ec into apache:master Jan 28, 2021
@boyuanzz boyuanzz deleted the oss_timer branch March 11, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants