New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10120] Add dynamic timer support to portable Flink #13783
Conversation
Run Java Flink PortableValidatesRunner Streaming |
Run Java Flink PortableValidatesRunner Batch |
Run Java Spark PortableValidatesRunner Batch |
Run Java Spark PortableValidatesRunner Streaming |
Codecov Report
@@ Coverage Diff @@
## master #13783 +/- ##
==========================================
- Coverage 82.76% 82.74% -0.02%
==========================================
Files 466 466
Lines 57525 57525
==========================================
- Hits 47612 47601 -11
- Misses 9913 9924 +11
Continue to review full report at Codecov.
|
Run Python_PVR_Flink PreCommit |
It seems like Spark doesn't support timers in portable execution. The changes I have made to java runner shared library can also used by Spark in the future. @ibzib |
Portable Spark supports timers in batch, but not streaming mode. |
Run Java Flink PortableValidatesRunner Streaming |
Run Java Flink PortableValidatesRunner Batch |
Run Java Flink PortableValidatesRunner Streaming |
Run Python_PVR_Flink PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the review! I'm going to merge this PR. Feel free to drop any comments here if you have any concerns @mxm . I'll follow up with any comments. |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.