Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10961] Enable strict dependency checking on sdks/java/io/hadoop-format #13799

Merged
merged 2 commits into from Jan 27, 2021

Conversation

shehzaadn-vd
Copy link
Contributor

Moved here from PR# 13688 per @ibzib's request.

R: @ibzib, please add other folks if needed.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@shehzaadn-vd shehzaadn-vd changed the title enable strict dependency checking on sdks/java/io/hadoop-format Enable strict dependency checking on sdks/java/io/hadoop-format Jan 23, 2021
@shehzaadn-vd shehzaadn-vd changed the title Enable strict dependency checking on sdks/java/io/hadoop-format [BEAM-10961] Enable strict dependency checking on sdks/java/io/hadoop-format Jan 23, 2021
@ibzib
Copy link
Contributor

ibzib commented Jan 26, 2021

LGTM, but we should get a second opinion on the log4j thing from someone who knows this module better. Perhaps @aromanenko-dev ?

@aromanenko-dev
Copy link
Contributor

Run Java HadoopFormatIO Performance Test

@aromanenko-dev
Copy link
Contributor

Well, I don't know why specific Log4j version was used for testing (it was added even before my code refactoring) but if all tests pass then, seems, we don't need that anymore. So, it LGTM in general for me.

Maybe @iemejia recalls something on this.

@aromanenko-dev
Copy link
Contributor

@shehzaadn-vd Please, don't forget to add a Jira prefix to commit messages as well.

@iemejia
Copy link
Member

iemejia commented Jan 26, 2021

Well, I don't know why specific Log4j version was used for testing (it was added even before my code refactoring) but if all tests pass then, seems, we don't need that anymore. So, it LGTM in general for me.

Maybe @iemejia recalls something on this.

No idea but in any case even if used it should have not had that scope but testRuntimeOnly so good to remove save if some test is not happy

@shehzaadn-vd shehzaadn-vd force-pushed the sdks-io-hadoop branch 3 times, most recently from b78db30 to 465ebeb Compare January 27, 2021 13:54
@shehzaadn-vd
Copy link
Contributor Author

@aromanenko-dev I didn't mean to ignore your comment about jira prefixes on commit messages. I just saw it late. Apologies. Hope I can get a pass this time!

@aromanenko-dev
Copy link
Contributor

@shehzaadn-vd Not a problem, I'll squash before merge and fix a comment message

@aromanenko-dev aromanenko-dev merged commit ed5b117 into apache:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants