Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-11715] [cherry-pick] Partial revert of "Combiner packing in Dataflow" (#13763) #13901

Conversation

yifanmai
Copy link
Contributor

@yifanmai yifanmai commented Feb 5, 2021

This reverts the use of translations.pack_combiners in DataflowRunner added in #13763, but preserves other changes (i.e. minor bug fix in translations.pack_combiners, disabling optimizations by default, and testing that translations.pack_combiners is disabled).

This reason for the revert is that translations.pack_combiners results in packed CombinePerKey transforms without subtransforms which is not accepted by Dataflow, and that Pipeline.from_runner_api will break cross-language pipelines

Cherry-pick of #13884.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

…#13763) (apache#13884)

* Revert "[BEAM-11695] Combiner packing in Dataflow (apache#13763)"

This reverts commit 3b51aaa.

* Make pack_combiners optional

* Don't revert translations.py

* Add missing ValidatesRunner
@yifanmai
Copy link
Contributor Author

yifanmai commented Feb 5, 2021

R: @chamikaramj

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #13901 (3903998) into release-2.28.0 (091cd88) will increase coverage by 0.00%.
The diff coverage is 56.52%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-2.28.0   #13901   +/-   ##
===============================================
  Coverage           82.84%   82.85%           
===============================================
  Files                 466      466           
  Lines               57584    57570   -14     
===============================================
- Hits                47705    47699    -6     
+ Misses               9879     9871    -8     
Impacted Files Coverage Δ
...ache_beam/runners/dataflow/ptransform_overrides.py 90.36% <ø> (-0.70%) ⬇️
...on/apache_beam/runners/dataflow/dataflow_runner.py 82.28% <44.44%> (-0.75%) ⬇️
...apache_beam/runners/portability/portable_runner.py 75.88% <100.00%> (+1.33%) ⬆️
...ks/python/apache_beam/runners/worker/data_plane.py 89.52% <0.00%> (-1.80%) ⬇️
sdks/python/apache_beam/dataframe/frames.py 91.15% <0.00%> (-0.83%) ⬇️
...apache_beam/runners/dataflow/internal/apiclient.py 73.13% <0.00%> (-0.35%) ⬇️
setup.py 0.00% <0.00%> (ø)
...hon/apache_beam/runners/worker/bundle_processor.py 93.83% <0.00%> (ø)
sdks/python/apache_beam/io/iobase.py 84.81% <0.00%> (+0.26%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f1b1e1...3903998. Read the comment docs.

@chamikaramj chamikaramj merged commit e11e768 into apache:release-2.28.0 Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants