New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-9110] Bump jboss-marshalling to 2.0.10.Final #14043
Conversation
Run Java_Examples_Dataflow PreCommit |
R: @iemejia |
I am not sure how can we properly test this upgrade given that this is in the vendoring dependency, and fully testing it would probably require a release of the vendored dependency. |
I'm now feeling this dependency is not needed for Beam's use of gRPC. It seems that the dependency was added in https://github.com/apache/beam/pull/10578/files to remove the errors from Linkage Checker. If Beam's using gRPC does not touch JBoss marshalling, we don't need the dependency here. (This means the Linkage Checker was showing false positive errors) @masahitojp Do you see Beam (or Beam's use of gRPC) uses jboss-marshalling? |
@masahitojp - Would you be able to look at the last question from @suztomo ? |
Now jboss-marshalling has been removed from the vendored gRPC dependencies. I think you don't need this PR any more. |
Bump jboss-marshalling to 2.0.10.Final
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.