Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-10961] enable strict dependency checking for sdks/java/io/contextualtextio #14049

Merged
merged 2 commits into from
Feb 24, 2021
Merged

[BEAM-10961] enable strict dependency checking for sdks/java/io/contextualtextio #14049

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e326e77
[BEAM-10961] enable strict dependency checking for sdks/java/io/conte…
shehzaadn-vd Feb 24, 2021
956875f
[BEAM-10961] (1) nitpick: space (2) add reference to BEAM-11761
shehzaadn-vd Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions sdks/java/io/contextualtextio/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,22 @@

plugins { id 'org.apache.beam.module' }
applyJavaNature(
enableStrictDependencies:true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spacing

Suggested change
enableStrictDependencies:true,
enableStrictDependencies: true,

automaticModuleName: 'org.apache.beam.sdk.io.contextualtextio',
)

description = "Apache Beam :: SDKs :: Java :: Contextual-Text-IO"
ext.summary = "Context-aware Text IO."

dependencies {
compile library.java.vendored_guava_26_0_jre
compile library.java.protobuf_java
compile project(path: ":sdks:java:core", configuration: "shadow")
testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
compile library.java.protobuf_java
permitUnusedDeclared library.java.protobuf_java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the JIRA here

compile library.java.slf4j_api
compile library.java.vendored_guava_26_0_jre
compile library.java.vendored_grpc_1_26_0

testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
testCompile library.java.guava_testlib
testCompile library.java.junit
testCompile library.java.hamcrest_core
Expand Down