Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-10961] enable strict dependency checking for sdks/java/io/expansion-service #14051

Merged
merged 2 commits into from
Feb 24, 2021
Merged

[BEAM-10961] enable strict dependency checking for sdks/java/io/expansion-service #14051

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba923b5
[BEAM-10961] enable strict dependency checking for sdks/java/io/expan…
shehzaadn-vd Feb 24, 2021
2905fb4
[BEAM-10961] add references to BEAM-11761
shehzaadn-vd Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdks/java/io/expansion-service/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ apply plugin: 'application'
mainClassName = "org.apache.beam.sdk.expansion.service.ExpansionService"

applyJavaNature(
enableStrictDependencies:true,
automaticModuleName: 'org.apache.beam.sdk.io.expansion.service',
exportJavadoc: false,
validateShadowJar: false,
Expand All @@ -32,10 +33,14 @@ ext.summary = "Expansion service serving several Java IOs"

dependencies {
compile project(":sdks:java:expansion-service")
permitUnusedDeclared project(":sdks:java:expansion-service")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to the jira (just once at the beginning is okay, doesn't have to be on every line)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind, I'll do it on every line. Adding it to every line allows easier identification of lines to be looked at by whoever works on BEAM-11761.

compile project(":sdks:java:io:kafka")
permitUnusedDeclared project(":sdks:java:io:kafka")
compile project(":sdks:java:io:jdbc")
permitUnusedDeclared project(":sdks:java:io:jdbc")
// Include postgres so it can be used with external JDBC
compile library.java.postgres
permitUnusedDeclared library.java.postgres
runtime library.java.kafka_clients
runtime library.java.slf4j_jdk14
}