Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-10961] enable strict dependency checking for sdks/java/io/kinesis #14058

Merged
merged 2 commits into from
Feb 24, 2021
Merged

[BEAM-10961] enable strict dependency checking for sdks/java/io/kinesis #14058

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e462e8f
[BEAM-10961] enable strict dependency checking for sdks/java/io/kinesis
shehzaadn-vd Feb 24, 2021
6f088dc
[BEAM-10961] (1) fix spacing (2) add reference to BEAM-11761
shehzaadn-vd Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 6 additions & 7 deletions sdks/java/io/kinesis/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
*/

plugins { id 'org.apache.beam.module' }
applyJavaNature(automaticModuleName: 'org.apache.beam.sdk.io.kinesis')
applyJavaNature(enableStrictDependencies:true,automaticModuleName: 'org.apache.beam.sdk.io.kinesis')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
applyJavaNature(enableStrictDependencies:true,automaticModuleName: 'org.apache.beam.sdk.io.kinesis')
applyJavaNature(enableStrictDependencies: true, automaticModuleName: 'org.apache.beam.sdk.io.kinesis')

provideIntegrationTestingDependencies()
enableJavaPerformanceTesting()

Expand All @@ -31,22 +31,21 @@ test {

dependencies {
compile project(path: ":sdks:java:core", configuration: "shadow")
compile library.java.slf4j_api
compile library.java.joda_time
compile library.java.jackson_dataformat_cbor
compile library.java.guava
compile library.java.aws_java_sdk_cloudwatch
compile library.java.aws_java_sdk_core
compile library.java.aws_java_sdk_kinesis
compile library.java.commons_lang3
compile library.java.guava
compile library.java.joda_time
compile library.java.slf4j_api
compile "com.amazonaws:amazon-kinesis-client:1.13.0"
compile "com.amazonaws:amazon-kinesis-producer:0.14.1"
compile "commons-lang:commons-lang:2.6"
compile library.java.vendored_guava_26_0_jre
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a transitive dependency pulled in by :sdks:java:core.

testCompile project(path: ":sdks:java:io:common", configuration: "testRuntime")
testCompile library.java.junit
testCompile library.java.mockito_core
testCompile library.java.guava_testlib
testCompile library.java.hamcrest_core
testCompile library.java.hamcrest_library
testCompile library.java.powermock
testCompile library.java.powermock_mockito
testCompile library.java.testcontainers_localstack
Expand Down
4 changes: 3 additions & 1 deletion sdks/java/io/kinesis/expansion-service/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ apply plugin: 'application'
mainClassName = "org.apache.beam.sdk.expansion.service.ExpansionService"

applyJavaNature(

enableStrictDependencies:true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
enableStrictDependencies:true,
enableStrictDependencies: true,

automaticModuleName: 'org.apache.beam.sdk.io.kinesis.expansion.service',
exportJavadoc: false,
validateShadowJar: false,
Expand All @@ -33,6 +33,8 @@ ext.summary = "Expansion service serving KinesisIO"

dependencies {
compile project(":sdks:java:expansion-service")
permitUnusedDeclared project(":sdks:java:expansion-service")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link the JIRA

compile project(":sdks:java:io:kinesis")
permitUnusedDeclared project(":sdks:java:io:kinesis")
runtime library.java.slf4j_jdk14
}