[BEAM-10961] turn on enableStrictDependencies globally #14114
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14114 +/- ##
==========================================
+ Coverage 83.04% 83.12% +0.07%
==========================================
Files 469 469
Lines 58488 58869 +381
==========================================
+ Hits 48573 48934 +361
- Misses 9915 9935 +20
Continue to review full report at Codecov.
|
|
Run Java PreCommit |
buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
Outdated
Show resolved
Hide resolved
|
@ibzib Java Wordcount Direct Runner on MacOS is failing with: Suggests this will be a flappy check going forward. Shall we set the compiler JVM max heap size in BeamModulePlugin.groovy? |
|
Run Java_Examples_Dataflow PreCommit |
| @@ -30,6 +30,7 @@ val library = project.extensions.extraProperties["library"] as Map<String, Map<S | |||
| dependencies { | |||
| compile(library.getValue("groovy").getValue("groovy_all")) | |||
| compile("commons-cli:commons-cli:1.2") | |||
| permitUnusedDeclared("commons-cli:commons-cli:1.2") // BEAM-11761 | |||
There was a problem hiding this comment.
@ibzib do you think this is necessary for the "release" project?
There was a problem hiding this comment.
Not sure, but permitUnusedDeclared is fine either way.
| @@ -30,6 +30,7 @@ val library = project.extensions.extraProperties["library"] as Map<String, Map<S | |||
| dependencies { | |||
| compile(library.getValue("groovy").getValue("groovy_all")) | |||
| compile("commons-cli:commons-cli:1.2") | |||
| permitUnusedDeclared("commons-cli:commons-cli:1.2") // BEAM-11761 | |||
There was a problem hiding this comment.
Not sure, but permitUnusedDeclared is fine either way.
|
@shehzaadn-vd Can you please squash the commit history? |
shehzaadn-vd
force-pushed
the
enable-global-dep-check
branch
from
e0fd45e
to
7b31eb8
Compare
done! |
|
Run Java_Examples_Dataflow PreCommit |
|
Run Portable_Python PreCommit |
Now that most projects have been validated for strict dependency checking, we are turning on enableStrictDependencies globally, removing enableStrictDependencies:true from all projects that have been corrected (and necessary changes merged) so that they can inherit this global switch, and adding enableStrictDependencies:false for the small number of files which are still under review in other PRs (thus overriding the global switch).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.