[BEAM-12081] Fix AwsOptions Jackson (de)serialization of integer values #14400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. Can you please check (and fix if possible) this for the amazon-web-services2 module too. Also can you please squash all commits into a a single one and put the updated issue title. Thanks! |
iemejia
changed the title
|
@iemejia done, thanks for taking a look. |
aromanenko-dev
requested changes
Apr 1, 2021
| @@ -239,4 +242,22 @@ public void testAwsHttpClientConfigurationSerializationDeserialization() throws | |||
| assertEquals(1000, clientConfigurationDeserialized.getConnectionMaxIdleMillis()); | |||
| assertEquals(300, clientConfigurationDeserialized.getSocketTimeout()); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Could you add a test case with "-1" value, mentioned in Jira?
aromanenko-dev
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added more details in https://issues.apache.org/jira/browse/BEAM-12081
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.