New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-6597] Use runner capabilities to activate short ids. #14577
Conversation
R: @y1chi |
Codecov Report
@@ Coverage Diff @@
## master #14577 +/- ##
==========================================
+ Coverage 83.60% 83.63% +0.02%
==========================================
Files 445 890 +445
Lines 58980 118076 +59096
==========================================
+ Hits 49310 98748 +49438
- Misses 9670 19328 +9658
Continue to review full report at Codecov.
|
@@ -1535,6 +1535,15 @@ message StandardProtocols { | |||
} | |||
} | |||
|
|||
// These URNs are used to indicate capabilities of runner that cannot that an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "cannot that".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Run Java PreCommit |
retest this please |
Run Java PreCommit |
This PR does not change any Python code. |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.