Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6597] Use runner capabilities to activate short ids. #14577

Merged
merged 2 commits into from Apr 20, 2021

Conversation

robertwb
Copy link
Contributor


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@robertwb
Copy link
Contributor Author

R: @y1chi

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #14577 (28ca249) into master (35759a7) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14577      +/-   ##
==========================================
+ Coverage   83.60%   83.63%   +0.02%     
==========================================
  Files         445      890     +445     
  Lines       58980   118076   +59096     
==========================================
+ Hits        49310    98748   +49438     
- Misses       9670    19328    +9658     
Impacted Files Coverage Δ
.../build/srcs/sdks/python/apache_beam/tools/utils.py 67.74% <0.00%> (-1.49%) ⬇️
.../srcs/sdks/python/apache_beam/utils/proto_utils.py 62.50% <0.00%> (-1.14%) ⬇️
...sdks/python/apache_beam/internal/metrics/metric.py 86.17% <0.00%> (-1.07%) ⬇️
.../srcs/sdks/python/apache_beam/utils/sharded_key.py 87.50% <0.00%> (-0.74%) ⬇️
.../build/srcs/sdks/python/apache_beam/utils/retry.py 85.43% <0.00%> (-0.68%) ⬇️
...ild/srcs/sdks/python/apache_beam/utils/counters.py 86.74% <0.00%> (-0.47%) ⬇️
...eam/runners/interactive/caching/streaming_cache.py 95.72% <0.00%> (-0.40%) ⬇️
...8/build/srcs/sdks/python/apache_beam/utils/urns.py 88.70% <0.00%> (-0.36%) ⬇️
...sdks/python/apache_beam/utils/subprocess_server.py 53.14% <0.00%> (-0.27%) ⬇️
...ld/srcs/sdks/python/apache_beam/utils/processes.py 87.03% <0.00%> (-0.24%) ⬇️
... and 474 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9605f...28ca249. Read the comment docs.

@@ -1535,6 +1535,15 @@ message StandardProtocols {
}
}

// These URNs are used to indicate capabilities of runner that cannot that an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "cannot that".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@y1chi y1chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@y1chi
Copy link
Contributor

y1chi commented Apr 19, 2021

Run Java PreCommit

@robertwb
Copy link
Contributor Author

retest this please

@robertwb
Copy link
Contributor Author

Run Java PreCommit

@robertwb
Copy link
Contributor Author

This PR does not change any Python code.

@robertwb robertwb merged commit 07ffbb1 into apache:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants