Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint breakage from Merge pull request #13617 from [BEAM-11289] [Python] Integrat… #14710

Merged
merged 1 commit into from May 3, 2021

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented May 3, 2021

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #14710 (c57cce3) into master (c644b06) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14710   +/-   ##
=======================================
  Coverage   83.60%   83.60%           
=======================================
  Files         442      442           
  Lines       59246    59246           
=======================================
+ Hits        49531    49532    +1     
+ Misses       9715     9714    -1     
Impacted Files Coverage Δ
...am/examples/snippets/transforms/elementwise/map.py
.../sdks/python/apache_beam/io/external/gcp/pubsub.py
...s/sdks/python/apache_beam/runners/worker/logger.py
.../sdks/python/apache_beam/transforms/deduplicate.py
...38/build/srcs/sdks/python/apache_beam/io/avroio.py
...m/runners/portability/flink_uber_jar_job_server.py
...ache_beam/runners/interactive/caching/cacheable.py
...beam/portability/api/beam_artifact_api_pb2_grpc.py
...am/testing/benchmarks/chicago_taxi/trainer/task.py
...s/python/apache_beam/runners/portability/stager.py
... and 874 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c644b06...c57cce3. Read the comment docs.

@pabloem
Copy link
Member Author

pabloem commented May 3, 2021

r: @TheNeuralBit

@pabloem pabloem changed the title Add lint exception Fix lint breakage from Merge pull request #13617 from [BEAM-11289] [Python] Integrat… May 3, 2021
Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It would be nice to understand why this happened. Presumably this is happening because the recommendation client added another module under google.cloud, but there are already several other modules under google.cloud. What's different about recommendations?

@TheNeuralBit TheNeuralBit merged commit 9102530 into apache:master May 3, 2021
@pabloem pabloem deleted the fix-pr-13617 branch May 3, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants