Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12352] Skip GcsIOIntegrationTest.test_copy{,_batch}_rewrite_token tests #14851

Merged
merged 1 commit into from
May 20, 2021

Conversation

udim
Copy link
Member

@udim udim commented May 20, 2021

These rely on a GCS feature that is not currently working.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

…en tests

These rely on a GCS feature that is not currently working.
@udim udim requested a review from ibzib May 20, 2021 20:07
@udim
Copy link
Member Author

udim commented May 20, 2021

Run Python 3.6 PostCommit

Copy link
Contributor

@ibzib ibzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Udi!

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #14851 (a9d1f3e) into master (1ee9a42) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14851      +/-   ##
==========================================
+ Coverage   83.67%   83.77%   +0.10%     
==========================================
  Files         440      434       -6     
  Lines       59053    58266     -787     
==========================================
- Hits        49412    48812     -600     
+ Misses       9641     9454     -187     
Impacted Files Coverage Δ
...sdks/python/apache_beam/portability/python_urns.py
...srcs/sdks/python/apache_beam/io/localfilesystem.py
...gcp/datastore/v1new/datastore_write_it_pipeline.py
...cs/sdks/python/apache_beam/io/gcp/gcsfilesystem.py
.../build/srcs/sdks/python/apache_beam/io/aws/s3io.py
...dks/python/apache_beam/transforms/create_source.py
.../examples/snippets/transforms/aggregation/count.py
.../srcs/sdks/python/apache_beam/transforms/window.py
...ild/srcs/sdks/python/apache_beam/utils/profiler.py
...pache_beam/runners/portability/portable_metrics.py
... and 864 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d253f9...a9d1f3e. Read the comment docs.

@udim
Copy link
Member Author

udim commented May 20, 2021

Verified tests are being skipped: https://ci-beam.apache.org/job/beam_PostCommit_Python36_PR/117/testReport/apache_beam.io.gcp.gcsio_integration_test/GcsIOIntegrationTest/

Postcommit still fails though for another test.

@udim udim merged commit 40326dd into apache:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants