Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12334] Re-use java 11 flag in build.gradle #14892

Merged
merged 2 commits into from Jun 15, 2021

Conversation

kileys
Copy link
Contributor

@kileys kileys commented May 26, 2021

Reuse the flag to compile and run in Java 11 for the Jenkins job


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@kileys
Copy link
Contributor Author

kileys commented Jun 1, 2021

R: @amaliujia

@amaliujia
Copy link
Contributor

LGTM

@amaliujia
Copy link
Contributor

amaliujia commented Jun 3, 2021

Do you need to run any postcommits?

@kileys
Copy link
Contributor Author

kileys commented Jun 3, 2021

Dataflow Runner Nexmark Tests

@kileys
Copy link
Contributor Author

kileys commented Jun 3, 2021

Run SQL PostCommit

@kileys
Copy link
Contributor Author

kileys commented Jun 3, 2021

Run Dataflow Runner V2 Java 11 Nexmark Tests

@kileys
Copy link
Contributor Author

kileys commented Jun 3, 2021

Need to run seed job to test the updated job
@amaliujia

@amaliujia
Copy link
Contributor

Created #14956 and trigger seed job there.

@kileys
Copy link
Contributor Author

kileys commented Jun 8, 2021

Run Java PreCommit

@kileys
Copy link
Contributor Author

kileys commented Jun 8, 2021

Run Java_Examples_Dataflow_Java11 PreCommit

@kileys
Copy link
Contributor Author

kileys commented Jun 8, 2021

Run Java PreCommit

@kileys
Copy link
Contributor Author

kileys commented Jun 8, 2021

@amaliujia the test is going to time out because of an unrelated issue https://issues.apache.org/jira/browse/BEAM-12452
but the update to the test is running without compile errors

https://gradle.com/s/r3vyrald6fhkm
https://gradle.com/s/vyqtqy22wr2iu
https://gradle.com/s/njd3vfdwnglv2

@amaliujia
Copy link
Contributor

Run Java PreCommit

@amaliujia
Copy link
Contributor

Run Dataflow Runner V2 Java 11 Nexmark Tests

@amaliujia
Copy link
Contributor

Ah I guess I need to trigger another seed job?

@kileys
Copy link
Contributor Author

kileys commented Jun 14, 2021

Ah I guess I need to trigger another seed job?

Unfortunately, yeah

@amaliujia
Copy link
Contributor

Ah I guess I need to trigger another seed job?

Unfortunately, yeah

Done

@kileys
Copy link
Contributor Author

kileys commented Jun 15, 2021

Run Dataflow Runner V2 Java 11 Nexmark Tests

@amaliujia amaliujia merged commit 3615801 into apache:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants