Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12281] Drop support for Flink 1.10 #14906

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

iemejia
Copy link
Member

@iemejia iemejia commented May 28, 2021

@iemejia iemejia requested review from dmvk and ibzib May 28, 2021 19:59
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #14906 (22575c7) into master (00eb420) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14906      +/-   ##
==========================================
+ Coverage   83.78%   83.79%   +0.01%     
==========================================
  Files         435      435              
  Lines       58423    58423              
==========================================
+ Hits        48948    48956       +8     
+ Misses       9475     9467       -8     
Impacted Files Coverage Δ
...ython/apache_beam/io/gcp/experimental/spannerio.py
...pache_beam/runners/worker/worker_id_interceptor.py
...examples/snippets/transforms/elementwise/filter.py
...ache_beam/runners/interactive/caching/cacheable.py
...uild/srcs/sdks/python/apache_beam/io/tfrecordio.py
...python/apache_beam/examples/wordcount_dataframe.py
...e_beam/examples/complete/game/hourly_team_score.py
...examples/snippets/transforms/aggregation/sample.py
...s/sdks/python/apache_beam/transforms/ptransform.py
...n/apache_beam/examples/cookbook/bigquery_schema.py
... and 860 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00eb420...22575c7. Read the comment docs.

Copy link
Contributor

@je-ik je-ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup!
I have one generic question regarding the policy of which version of the runner should be run on the CI. Maybe we can discuss that on the ML.

@@ -35,7 +35,7 @@
# HARNESS_IMAGES_TO_PULL='gcr.io/<IMAGE_REPOSITORY>/python:latest gcr.io/<IMAGE_REPOSITORY>/java:latest' \
# JOB_SERVER_IMAGE=gcr.io/<IMAGE_REPOSITORY>/job-server-flink:latest \
# ARTIFACTS_DIR=gs://<bucket-for-artifacts> \
# FLINK_DOWNLOAD_URL=https://archive.apache.org/dist/flink/flink-1.10.1/flink-1.10.1-bin-scala_2.11.tgz \
# FLINK_DOWNLOAD_URL=https://archive.apache.org/dist/flink/flink-1.12.3/flink-1.12.3-bin-scala_2.11.tgz \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I believe the currently released version of 1.12.x is 1.12.4.
Unrelated: Do we have a policy about whic version to run on jenkins? Should it be the most recent one? Looks like we are changing from the last supported (1.10) to the second newest, is this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I kept 1.12.3 because this is run in Dataproc and that's the currently supported version on Dataproc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, understood.

Copy link
Member

@dmvk dmvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉

Copy link
Contributor

@ibzib ibzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia iemejia merged commit 511fb05 into apache:master Jun 2, 2021
@iemejia iemejia deleted the BEAM-12281-flink-remove-1.10 branch June 7, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants