New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-12419] Add Timeout and WaitForReady support in java gRPC calls #14923
Conversation
1. Add JobServerTimeout option that defaults to 60s to all job server requests (with exception to the ones that are expected to last long or hang) to be on Par with python BEAM-7933 2. Add WaitForReady for ExternalEnvironment
Let me know if you think we should add timeout in external_payload as well |
@ibzib Could you help review this PR? |
Run Python_PVR_Flink PreCommit |
Run Java PreCommit |
1 similar comment
Run Java PreCommit |
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PortablePipelineOptions.java
Outdated
Show resolved
Hide resolved
runners/portability/java/src/main/java/org/apache/beam/runners/portability/PortableRunner.java
Outdated
Show resolved
Hide resolved
runners/portability/java/src/main/java/org/apache/beam/runners/portability/PortableRunner.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/beam/runners/fnexecution/environment/ExternalEnvironmentFactory.java
Outdated
Show resolved
Hide resolved
Run Java_Examples_Dataflow PreCommit |
Run Java PreCommit |
1 similar comment
Run Java PreCommit |
@ibzib Could you help take another pass? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Run Java Flink PortableValidatesRunner Batch |
Looks like this change broke the portable spark runner: https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/4428/ Are you aware of the breakage? Can we roll this back? |
Thanks for bringing this up, let me take a look if we can fix them soon or we can roll it back. |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.