Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12419] Add Timeout and WaitForReady support in java gRPC calls #14923

Merged
merged 3 commits into from Jun 3, 2021
Merged

[BEAM-12419] Add Timeout and WaitForReady support in java gRPC calls #14923

merged 3 commits into from Jun 3, 2021

Conversation

kw2542
Copy link
Contributor

@kw2542 kw2542 commented Jun 1, 2021

  1. Add JobServerTimeout option that defaults to 60s to all job server requests (with exception to the ones that are expected to last long or hang) to be on Par with python BEAM-7933
  2. Add WaitForReady for ExternalEnvironment

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

1. Add JobServerTimeout option that defaults to 60s to all job server requests (with exception to the ones that are expected to last long or hang) to be on Par with python BEAM-7933
2. Add WaitForReady for ExternalEnvironment
@kw2542
Copy link
Contributor Author

kw2542 commented Jun 1, 2021

Let me know if you think we should add timeout in external_payload as well

@kw2542
Copy link
Contributor Author

kw2542 commented Jun 1, 2021

@ibzib Could you help review this PR?

@kw2542
Copy link
Contributor Author

kw2542 commented Jun 2, 2021

Run Python_PVR_Flink PreCommit

@kw2542
Copy link
Contributor Author

kw2542 commented Jun 2, 2021

Run Java PreCommit

1 similar comment
@kw2542
Copy link
Contributor Author

kw2542 commented Jun 2, 2021

Run Java PreCommit

@xinyuiscool xinyuiscool requested a review from ibzib June 2, 2021 17:24
@kw2542
Copy link
Contributor Author

kw2542 commented Jun 2, 2021

Run Java_Examples_Dataflow PreCommit

@kw2542
Copy link
Contributor Author

kw2542 commented Jun 2, 2021

Run Java PreCommit

1 similar comment
@kw2542
Copy link
Contributor Author

kw2542 commented Jun 2, 2021

Run Java PreCommit

@kw2542 kw2542 requested a review from ibzib June 2, 2021 22:56
@kw2542
Copy link
Contributor Author

kw2542 commented Jun 3, 2021

@ibzib Could you help take another pass?

Copy link
Contributor

@ibzib ibzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibzib
Copy link
Contributor

ibzib commented Jun 3, 2021

Run Java Flink PortableValidatesRunner Batch

@ibzib ibzib merged commit fdccad2 into apache:master Jun 3, 2021
@kw2542 kw2542 deleted the BEAM-12419 branch June 3, 2021 20:14
@apilloud
Copy link
Member

Looks like this change broke the portable spark runner: https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/4428/

Are you aware of the breakage? Can we roll this back?

@kw2542
Copy link
Contributor Author

kw2542 commented Jun 11, 2021

Looks like this change broke the portable spark runner: https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/4428/

Are you aware of the breakage? Can we roll this back?

Thanks for bringing this up, let me take a look if we can fix them soon or we can roll it back.

@kw2542
Copy link
Contributor Author

kw2542 commented Jun 11, 2021

@apilloud Found the RC and fixed in #14995, could you help take a look ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants