-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-12028] Add contact information to NotImplementedError #14967
Merged
TheNeuralBit
merged 7 commits into
apache:master
from
TheNeuralBit:not-implemented-error-message
Jun 11, 2021
Merged
[BEAM-12028] Add contact information to NotImplementedError #14967
TheNeuralBit
merged 7 commits into
apache:master
from
TheNeuralBit:not-implemented-error-message
Jun 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheNeuralBit
force-pushed
the
not-implemented-error-message
branch
from
June 8, 2021 18:31
3ea9698
to
fe3d8af
Compare
TheNeuralBit
force-pushed
the
not-implemented-error-message
branch
from
June 8, 2021 20:50
fe3d8af
to
5101c5f
Compare
Run Python PreCommit |
2 similar comments
Run Python PreCommit |
Run Python PreCommit |
robertwb
approved these changes
Jun 11, 2021
@@ -358,25 +371,33 @@ def wrapper(*args, **kwargs): | |||
|
|||
wrapper.__name__ = name | |||
wrapper.__doc__ = ( | |||
f":meth:`pandas.{base_type.__name__}.{name}` is not supported in the " | |||
f"Beam DataFrame API {reason_data['explanation']}") | |||
f":meth:`{_prettify_pandas_type(base_type)}.{name}` is not supported in " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we say not yet supported, or otherwise give an indication that this is subject to change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have contact information in pydoc for these operations, but we should also include it in the error message so users know what to do as soon as they run into it. Required plumbing the base type through
not_implemented_method
.I also went ahead and fixed some links that I noticed are using the wrong format in their docstrings.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.