[BEAM-2492] Have PipelineOptions DisplayData filter out attributes marked with @org.apache.beam.sdk.options.Hidden #14970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Java PreCommit |
|
LGTM. Just need to get the tests to pass. |
|
Run Java PreCommit |
|
@pabloem Thanks for reviewing this. The Java ("Run Java PreCommit") checks keep failing because of elasticsearchIO tests and flink test, should rerun/retest help? |
|
can you rebase your change? that should help fix the tests, I expect. |
yzhang559
force-pushed
the
BEAM-2492_sdk-java-core
branch
from
2691d70
to
75fcb72
Compare
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
This was referenced Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interfaces marked with
Hiddenhave been hidden in getOptionSpecs, this change filters out methods annotated withHiddenand adds a unit test.Could you help review this change?
R: @lukecwik
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.