[BEAM-12401] Beam metrics made human readable in Flink's UI (and history server) #14978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @dmvk |
|
Run Java PreCommit |
|
We rely on metrics being in JSON format so the Python SDK can parse them. Can we find a way to solve BEAM-11212 so we can avoid breaking this functionality? |
|
What is the next step on this PR? Should we close this based on @ibzib's comment and explore a different direction? |
|
Closing this PR as we currently don't have a solution for @ibzib's comment and AFAIK it has been abandoned. We should leave the issue open though as it's still valid. @davidak09 Thanks for the contribution <3 Feel free to re-open the PR, if this is something you want to continue working on in your new role ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beam metric values (payload) are not readable in Flink's web UI and Flink history server. Similar problem affected Spark history server and it was resolved in BEAM-10294.
In this merge request beam metrics in Flink's UI are made human readable in the same format as they used to be.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.