Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][BEAM-12501] Don't attempt graceful shutdown in SubprocessServer on Windows #15021

Closed
wants to merge 1 commit into from

Conversation

TheNeuralBit
Copy link
Member

It looks like some gymnastics are required to do the equivalent of sending SIGINT on Windows. This PR opts to just skip the graceful shutdown.

WIP because it's still untested on Windows. I can start a machine to verify manually, but I'd like to find a way to test this continuously (see comment)

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@TheNeuralBit TheNeuralBit changed the title [WIP][BEAM-12501] Don't attempt graceful shutdown in SubprcessServer on Windows [WIP][BEAM-12501] Don't attempt graceful shutdown in SubprocessServer on Windows Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #15021 (e2eced9) into master (acc0f76) will decrease coverage by 0.01%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15021      +/-   ##
==========================================
- Coverage   83.77%   83.76%   -0.02%     
==========================================
  Files         439      439              
  Lines       59049    59052       +3     
==========================================
- Hits        49467    49462       -5     
- Misses       9582     9590       +8     
Impacted Files Coverage Δ
sdks/python/apache_beam/utils/subprocess_server.py 53.37% <22.22%> (+0.22%) ⬆️
...ks/python/apache_beam/runners/worker/data_plane.py 90.90% <0.00%> (-1.82%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 86.17% <0.00%> (-1.07%) ⬇️
sdks/python/apache_beam/transforms/util.py 95.86% <0.00%> (-0.18%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.85% <0.00%> (-0.16%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.94% <0.00%> (+0.12%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 90.24% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc0f76...e2eced9. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 5, 2022
@github-actions
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant