Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12490] Fixed test_harness_monitoring_infos_and_metadata precommit error #15033

Merged

Conversation

roger-mike
Copy link
Contributor

Fixed SdkWorkerTest.test_harness_monitoring_infos_and_metadata failing test


ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@roger-mike
Copy link
Contributor Author

R: @TheNeuralBit could you take a look?

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #15033 (11c3954) into master (5fb31eb) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15033      +/-   ##
==========================================
- Coverage   83.77%   83.75%   -0.02%     
==========================================
  Files         439      439              
  Lines       59052    59091      +39     
==========================================
+ Hits        49469    49492      +23     
- Misses       9583     9599      +16     
Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/gcsio.py 90.00% <ø> (ø)
sdks/python/apache_beam/utils/interactive_utils.py 87.80% <0.00%> (-7.32%) ⬇️
sdks/python/apache_beam/io/mongodbio.py 92.88% <0.00%> (-2.76%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 74.72% <0.00%> (-1.10%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 86.17% <0.00%> (-1.07%) ⬇️
...runners/interactive/display/pcoll_visualization.py 85.18% <0.00%> (-0.53%) ⬇️
...eam/runners/interactive/interactive_environment.py 90.33% <0.00%> (-0.38%) ⬇️
sdks/python/apache_beam/io/range_trackers.py 94.14% <0.00%> (-0.20%) ⬇️
sdks/python/apache_beam/runners/common.py 89.32% <0.00%> (+0.14%) ⬆️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.00% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fb31eb...11c3954. Read the comment docs.

Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the quick PR!

@TheNeuralBit
Copy link
Member

Run Python PreCommit

1 similar comment
@roger-mike
Copy link
Contributor Author

Run Python PreCommit

@TheNeuralBit TheNeuralBit merged commit 9af555d into apache:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants