Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8473] Fix generator send_type / return_type warning #15061

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

alexkoay
Copy link
Contributor

@alexkoay alexkoay commented Jun 22, 2021

This fixes the generator warning when None is used -- it was checking for None, while the typehint actually returns NoneType.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@alexkoay
Copy link
Contributor Author

R: @aaltay @charlesccychen

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #15061 (a232b9d) into master (8b66f37) will increase coverage by 0.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15061      +/-   ##
==========================================
+ Coverage   83.76%   84.23%   +0.46%     
==========================================
  Files         439      441       +2     
  Lines       59132    61480    +2348     
==========================================
+ Hits        49534    51786    +2252     
- Misses       9598     9694      +96     
Impacted Files Coverage Δ
sdks/python/apache_beam/typehints/typehints.py 93.34% <100.00%> (ø)
...on/apache_beam/runners/portability/spark_runner.py 64.81% <0.00%> (-4.76%) ⬇️
...ks/python/apache_beam/runners/worker/data_plane.py 91.21% <0.00%> (-1.52%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.25% <0.00%> (-0.54%) ⬇️
setup.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/dataframe/__init__.py 100.00% <0.00%> (ø)
...ks/python/apache_beam/ml/gcp/recommendations_ai.py 87.26% <0.00%> (ø)
...n/apache_beam/ml/gcp/recommendations_ai_test_it.py 69.76% <0.00%> (ø)
...hon/apache_beam/runners/worker/bundle_processor.py 93.98% <0.00%> (+0.03%) ⬆️
sdks/python/apache_beam/coders/coders.py 88.02% <0.00%> (+0.14%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b66f37...a232b9d. Read the comment docs.

@aaltay aaltay requested a review from udim June 29, 2021 04:12
@udim
Copy link
Member

udim commented Jun 30, 2021

Run Python PreCommit

@udim
Copy link
Member

udim commented Jun 30, 2021

Run Python PreCommit

1 similar comment
@aaltay
Copy link
Member

aaltay commented Jul 1, 2021

Run Python PreCommit

@udim udim merged commit 9c24ba6 into apache:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants