Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10955] Fix Flink Java Runner test flake: Could not find Flink job #15107

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

benWize
Copy link
Contributor

@benWize benWize commented Jun 30, 2021

Testing flakiness in Java Precommit: could not find Flink job

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@benWize
Copy link
Contributor Author

benWize commented Jun 30, 2021

Run Java PreCommit

@benWize
Copy link
Contributor Author

benWize commented Jun 30, 2021

@benWize
Copy link
Contributor Author

benWize commented Jun 30, 2021

Run Java PreCommit

@benWize
Copy link
Contributor Author

benWize commented Jun 30, 2021

Run Python_PVR_Flink PreCommit

@benWize
Copy link
Contributor Author

benWize commented Jun 30, 2021

Run Portable_Python PreCommit

@benWize
Copy link
Contributor Author

benWize commented Jun 30, 2021

Run Java PreCommit

@benWize benWize marked this pull request as ready for review June 30, 2021 22:07
@benWize benWize changed the title [WIP][BEAM-10955] Flink Java Runner test flake: Could not find Flink job [BEAM-10955] Fix Flink Java Runner test flake: Could not find Flink job Jun 30, 2021
@benWize
Copy link
Contributor Author

benWize commented Jun 30, 2021

R: @tvalentyn. Would you help me to review this?

Copy link
Contributor

@ibzib ibzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibzib
Copy link
Contributor

ibzib commented Jun 30, 2021

Run Portable_Python PreCommit

1 similar comment
@benWize
Copy link
Contributor Author

benWize commented Jul 1, 2021

Run Portable_Python PreCommit

@ibzib ibzib merged commit f077ba5 into apache:master Jul 1, 2021
@benWize
Copy link
Contributor Author

benWize commented Jul 1, 2021

Thanks, @ibzib!

benWize added a commit to benWize/beam that referenced this pull request Jul 2, 2021
calvinleungyk pushed a commit to calvinleungyk/beam that referenced this pull request Jul 13, 2021
…ob (apache#15107)

* [BEAM-10955] Testing could not find Flink job

* [BEAM-10955] Add waitJobToBeReady call, test fix for Flink job not found flakiness

* [BEAM-10955] Remove unused import

* [BEAM-10955] Discard changes in website folder, remove loop used for testing
@benWize benWize deleted the BEAM-10955 branch August 5, 2021 22:04
calvinleungyk pushed a commit to calvinleungyk/beam that referenced this pull request Sep 22, 2021
…ob (apache#15107)

* [BEAM-10955] Testing could not find Flink job

* [BEAM-10955] Add waitJobToBeReady call, test fix for Flink job not found flakiness

* [BEAM-10955] Remove unused import

* [BEAM-10955] Discard changes in website folder, remove loop used for testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants