[BEAM-12662] Get Flink version from cluster. #15223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertwb
reviewed
Aug 23, 2021
| @@ -68,7 +68,7 @@ def executable_jar(self): | |||
| 'the scheme is specified. If using a local file path, make sure ' | |||
| 'the file exists; you may have to first build the job server ' | |||
| 'using `./gradlew runners:flink:%s:job-server:shadowJar`.' % | |||
| (self._executable_jar, self._flink_version)) | |||
| (self._executable_jar, self.flink_version()) | |||
There was a problem hiding this comment.
Is the server always up when we make this call?
There was a problem hiding this comment.
Since flink_version() sends a request to the Flink rest endpoint, I don't think we can ever guarantee the call is going to work. I'm thinking we should do both:
- We can try to give an error message with the correct Flink version, but if
flink_version()fails, give a message with a generic1.x. - Provide an actionable error message when the rest calls fail ("start a Flink cluster with rest enabled" etc.). This doesn't have to happen in this PR though, so I filed a separate ticket https://issues.apache.org/jira/browse/BEAM-12813.
Codecov Report
@@ Coverage Diff @@
## master #15223 +/- ##
==========================================
- Coverage 83.82% 83.79% -0.04%
==========================================
Files 441 440 -1
Lines 59706 59881 +175
==========================================
+ Hits 50051 50175 +124
- Misses 9655 9706 +51
Continue to review full report at Codecov.
|
robertwb
approved these changes
Sep 10, 2021
calvinleungyk
pushed a commit
to calvinleungyk/beam
that referenced
this pull request
Sep 22, 2021
* [BEAM-12662] Get Flink version from cluster. * [BEAM-12662] Log placeholder if we can't get Flink version from cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @robertwb
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.