[BEAM-12716] Update XLang Kafka taxi example to use BigQuery sink #15269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15269 +/- ##
==========================================
- Coverage 83.85% 83.81% -0.04%
==========================================
Files 441 441
Lines 59724 59746 +22
==========================================
- Hits 50079 50075 -4
- Misses 9645 9671 +26
Continue to review full report at Codecov.
|
|
R: @chamikaramj |
|
Run Python PreCommit |
chamikaramj
reviewed
Aug 9, 2021
| ride['passenger_count']) | ||
|
|
||
| def convert_kafka_record_to_dictionary(record): | ||
| if hasattr(record, 'value'): |
There was a problem hiding this comment.
Let's add a comment here to clarify. ("if" condition becomes true when reading with metadata).
|
two failing tests look irrelevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
--bq_datasetis given, use BigQuery sink. Otherwise, just print the log.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.