[BEAM-12634] JmsIO auto scaling feature #15464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Provide DefaultAutoscaler implementation - Add new autoscaler field to JmsIO
|
R: @lukecwik |
|
retest this please |
lukecwik
requested changes
Sep 8, 2021
There was a problem hiding this comment.
I was wrong in suggesting adding the getSplitBacklogBytes because we would need to expose a way for the autoscaler to know the current split which I believe will add a bunch of complexity to the current implementation that we don't want. So let's drop for now and then if it becomes needed it can be re-added.
Other then that just changes to comments.
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/AutoScaler.java
Outdated
Show resolved
Hide resolved
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/AutoScaler.java
Outdated
Show resolved
Hide resolved
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/AutoScaler.java
Show resolved
Hide resolved
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/AutoScaler.java
Outdated
Show resolved
Hide resolved
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/AutoScaler.java
Show resolved
Hide resolved
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/AutoScaler.java
Show resolved
Hide resolved
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/DefaultAutoscaler.java
Outdated
Show resolved
Hide resolved
- Delete getSplitBacklogBytes method - Add new comments Co-authored-by: Lukasz Cwik <lcwik@google.com>
|
what's the status of ths PR? : ) |
Hello, the PR has been reviewed by @lukecwik and changes made accordingly :-) |
lukecwik
approved these changes
Sep 10, 2021
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/AutoScaler.java
Outdated
Show resolved
Hide resolved
|
Run Java PreCommit |
calvinleungyk
pushed a commit
to calvinleungyk/beam
that referenced
this pull request
Sep 22, 2021
* [BEAM-12634]: Provide generic Autoscaler interface, - Provide DefaultAutoscaler implementation - Add new autoscaler field to JmsIO * [BEAM-12634]: Add Unit Tests for DefaultAutoScaler and mock custom Autoscaler * [BEAM-12634] => Apply suggestions from code review - Delete getSplitBacklogBytes method - Add new comments Co-authored-by: Lukasz Cwik <lcwik@google.com> * [BEAM-12634]: Fix tests and some JavaDoc comments consecutively to code review * [BEAM-12634]: Add comment on Autoscaler#getTotalBacklogBytes * Update sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/AutoScaler.java Co-authored-by: Lukasz Cwik <lcwik@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add autoscaling feature to JmsIO connector:
Provide a generic AutoScaler interface with the ability to implement getTotalbacklogBytes or/and getSplitBacklogBytes,
Provide a DefaultAutoScaler implementation (returning BACKLOG_UNKNOWN in both case),
add a new withAutoScaler configuration method to inject a custom auto scaler
https://issues.apache.org/jira/browse/BEAM-12634
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.