New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-12855] Infer result type when the composite type has Any #15476
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15476 +/- ##
=======================================
Coverage 83.74% 83.75%
=======================================
Files 443 443
Lines 60077 60088 +11
=======================================
+ Hits 50312 50327 +15
+ Misses 9765 9761 -4
Continue to review full report at Codecov.
|
R: @robertwb |
This commit will fix xlang validate runner test failure: BEAM-12805 |
Run XVR_Flink PostCommit |
I'm a little wary of this change. Currently, there's ambiguity as to what we should do if a transform and its surrounding composite both declare a (non-trivial) type constraint on an output PCollection. Previously, the inner transform would win, but this changes it to let the outer transform win. That might fix this test, but might break others. One option is to actually address the TODO here and implement (best-effort?) intersection. |
@robertwb Thanks for the comment. Could you elaborate more on intersection you mentioned? Does it mean intersection between the types before and after the inference? |
Yes, before (which presumably came from the inner transform(s)) and after this transform's type inference. |
@ihji - What is the next step on this PR? |
Any update on this? Should we close it? |
We can close this. |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.