Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12855] Infer result type when the composite type has Any #15476

Closed
wants to merge 1 commit into from

Conversation

ihji
Copy link
Contributor

@ihji ihji commented Sep 8, 2021

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #15476 (723996b) into master (823ab5a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15476   +/-   ##
=======================================
  Coverage   83.74%   83.75%           
=======================================
  Files         443      443           
  Lines       60077    60088   +11     
=======================================
+ Hits        50312    50327   +15     
+ Misses       9765     9761    -4     
Impacted Files Coverage Δ
sdks/python/apache_beam/pipeline.py 91.70% <100.00%> (+0.03%) ⬆️
sdks/python/apache_beam/typehints/typehints.py 93.45% <100.00%> (+0.10%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.39% <0.00%> (+0.12%) ⬆️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.95% <0.00%> (+0.15%) ⬆️
sdks/python/apache_beam/transforms/util.py 95.98% <0.00%> (+0.16%) ⬆️
...s/python/apache_beam/typehints/sharded_key_type.py 96.77% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc4ffd...723996b. Read the comment docs.

@ihji
Copy link
Contributor Author

ihji commented Sep 8, 2021

R: @robertwb

@ihji
Copy link
Contributor Author

ihji commented Sep 8, 2021

This commit will fix xlang validate runner test failure: BEAM-12805

@ihji
Copy link
Contributor Author

ihji commented Sep 9, 2021

Run XVR_Flink PostCommit

@robertwb
Copy link
Contributor

robertwb commented Sep 9, 2021

I'm a little wary of this change. Currently, there's ambiguity as to what we should do if a transform and its surrounding composite both declare a (non-trivial) type constraint on an output PCollection. Previously, the inner transform would win, but this changes it to let the outer transform win.

That might fix this test, but might break others.

One option is to actually address the TODO here and implement (best-effort?) intersection.

@ihji
Copy link
Contributor Author

ihji commented Sep 9, 2021

@robertwb Thanks for the comment. Could you elaborate more on intersection you mentioned? Does it mean intersection between the types before and after the inference?

@robertwb
Copy link
Contributor

Yes, before (which presumably came from the inner transform(s)) and after this transform's type inference.

@aaltay
Copy link
Member

aaltay commented Sep 23, 2021

@ihji - What is the next step on this PR?

@aaltay
Copy link
Member

aaltay commented Oct 7, 2021

Any update on this? Should we close it?

@ihji
Copy link
Contributor Author

ihji commented Oct 7, 2021

We can close this.

@ihji ihji closed this Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants