Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-12906] Add a dataframe extra for installing a pandas version supported by the DataFrame API #15528

Merged
merged 6 commits into from
Sep 28, 2021
Merged

[BEAM-12906] Add a dataframe extra for installing a pandas version supported by the DataFrame API #15528

merged 6 commits into from
Sep 28, 2021

Conversation

TheNeuralBit
Copy link
Member

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status 		Build Status
Build Status 		Build Status
Build Status
Build Status 		Build Status
Python --- Build Status
Build Status
Build Status 		Build Status
Build Status 		Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status 		Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Sep 17, 2021 •
edited
Loading

Codecov Report

Merging #15528 (cdc40c4) into master (53d5ebf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15528      +/-   ##
==========================================
- Coverage   83.78%   83.77%   -0.02%     
==========================================
  Files         444      444              
  Lines       60406    60410       +4     
==========================================
- Hits        50613    50606       -7     
- Misses       9793     9804      +11
Impacted Files Coverage Δ
sdks/python/apache_beam/dataframe/frames.py 94.85% <100.00%> (+0.06%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 90.24% <0.00%> (-4.88%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 88.47% <0.00%> (-1.39%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 90.42% <0.00%> (-1.07%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 75.60% <0.00%> (-0.98%) ⬇️
...runners/interactive/display/pcoll_visualization.py 85.85% <0.00%> (-0.51%) ⬇️
...eam/runners/interactive/interactive_environment.py 91.03% <0.00%> (-0.36%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.00% <0.00%> (-0.16%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.51% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f6efa5...cdc40c4. Read the comment docs.

@TheNeuralBit
Copy link
Member Author

Run Python 3.8 PostCommit

@TheNeuralBit TheNeuralBit changed the title [WIP][BEAM-12906] Add a dataframe extra for installing a pandas version supported by the DataFrame API [BEAM-12906] Add a dataframe extra for installing a pandas version supported by the DataFrame API Sep 17, 2021
@TheNeuralBit
Copy link
Member Author

R: @robertwb

TheNeuralBit
TheNeuralBit commented Sep 17, 2021
View reviewed changes
sdks/python/setup.py Outdated
@@ -305,7 +305,8 @@ def run(self):
'interactive': INTERACTIVE_BEAM,
'interactive_test': INTERACTIVE_BEAM_TEST,
'aws': AWS_REQUIREMENTS,
'azure': AZURE_REQUIREMENTS
'azure': AZURE_REQUIREMENTS,
'dataframe': ['pandas>=1.0,<1.3']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting here I need to be mindful of the conflict with #15525

@aaltay
Copy link
Member

aaltay commented Sep 17, 2021

Are there any checks in the code base where we check what pandas version is installed?

@TheNeuralBit
Copy link
Member Author

Are there any checks in the code base where we check what pandas version is installed?

Not in the implementation. There are some tests that change behavior based on pandas version (because of changes in pandas behavior), but that's it.

I'm not sure the risks of using an unsupported pandas version are great enough that we should forbid it completely.

@TheNeuralBit
Copy link
Member Author

Run Python 3.8 PostCommit

1 similar comment
@TheNeuralBit
Copy link
Member Author

Run Python 3.8 PostCommit

@TheNeuralBit
Copy link
Member Author

retest this please

@TheNeuralBit
Copy link
Member Author

Run Python 3.8 PostCommit

1 similar comment
@TheNeuralBit
Copy link
Member Author

Run Python 3.8 PostCommit

@TheNeuralBit TheNeuralBit merged commit 0111cff into apache:master Sep 28, 2021
dmitriikuzinepam pushed a commit to dmitriikuzinepam/beam that referenced this pull request Nov 2, 2021
@TheNeuralBit @dmitriikuzinepam
[BEAM-12906] Add a dataframe extra for installing a pandas version …
34d7a58 
…supported by the DataFrame API (apache#15528)

* Add 'dataframe' extra

* Update documentation to reference 'dataframe' extra

* Add dataframe to default extras

* fixup! Add 'dataframe' extra

* Install dataframe extra in installGcpTest task (for integration tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertwb robertwb robertwb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheNeuralBit @aaltay @robertwb