Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-11831] Partially Revert "[BEAM-11805] Replace user-agent for spanner (#13990)" #15591

Merged
merged 1 commit into from Oct 5, 2021

Conversation

TheNeuralBit
Copy link
Member

This partially reverts the changes from #13990. All of the changes to SpannerAccessor are reverted, except for the update to the comment that explains the purpose of the user-agent.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@TheNeuralBit
Copy link
Member Author

Run Java PostCommit

@TheNeuralBit
Copy link
Member Author

R: @allenpradeep

@TheNeuralBit
Copy link
Member Author

Run Java PreCommit

@TheNeuralBit
Copy link
Member Author

R: @nielm

@allenpradeep
Copy link
Contributor

@thiagotnunes

Just wanted to confirm if the original issue that was saw earlier(as part of BEAM-11805) in the Cloud Spanner library is fixed.

java.lang.IllegalArgumentException: Multiple entries with same key: user-agent=Apache_Beam_Java/2.29.0-SNAPSHOT and user-agent=spanner-java/3.2.1

@thiagotnunes
Copy link
Contributor

@allenpradeep 6.4.0 should have the fixes we need

@TheNeuralBit
Copy link
Member Author

Thanks for double-checking this. From jira:

./gradlew sdks:java:io:google-cloud-platform:dependencyReport shows:

+--- com.google.cloud:libraries-bom:22.0.0
...
|    +--- com.google.cloud:google-cloud-spanner:6.12.1 (c)

So we should have the upstream fix now. To be sure, I also ran the Java PostCommit on this PR, which is what caught BEAM-11805. Note that SpannerReadIT is still passing.

@TheNeuralBit
Copy link
Member Author

@allenpradeep does this look good given that we're on an appropriate version of the spanner client?

@TheNeuralBit
Copy link
Member Author

R: @lukecwik

@allenpradeep
Copy link
Contributor

LGTM
Sorry on the delay.

@TheNeuralBit
Copy link
Member Author

Thank you!

@TheNeuralBit TheNeuralBit merged commit 63211ee into apache:master Oct 5, 2021
dmitriikuzinepam pushed a commit to dmitriikuzinepam/beam that referenced this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants