New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-11831] Partially Revert "[BEAM-11805] Replace user-agent for spanner (#13990)" #15591
Conversation
Run Java PostCommit |
Run Java PreCommit |
R: @nielm |
Just wanted to confirm if the original issue that was saw earlier(as part of BEAM-11805) in the Cloud Spanner library is fixed.
|
@allenpradeep 6.4.0 should have the fixes we need |
Thanks for double-checking this. From jira:
So we should have the upstream fix now. To be sure, I also ran the Java PostCommit on this PR, which is what caught BEAM-11805. Note that SpannerReadIT is still passing. |
@allenpradeep does this look good given that we're on an appropriate version of the spanner client? |
R: @lukecwik |
LGTM |
Thank you! |
…nner (apache#13990)" (apache#15591) This partially reverts commit 4f78ab3.
This partially reverts the changes from #13990. All of the changes to
SpannerAccessor
are reverted, except for the update to the comment that explains the purpose of the user-agent.ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.